Bug 62898 - Expand Web Worker test coverage for onerror to have test for url/line numbers.
Summary: Expand Web Worker test coverage for onerror to have test for url/line numbers.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-17 12:02 PDT by David Levin
Modified: 2011-06-20 14:34 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.49 KB, patch)
2011-06-20 13:37 PDT, David Levin
dimich: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-06-17 12:02:46 PDT
See summary.
Comment 1 David Levin 2011-06-20 13:37:03 PDT
Created attachment 97853 [details]
Patch
Comment 2 Dmitry Titov 2011-06-20 13:49:37 PDT
Comment on attachment 97853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97853&action=review

r=me with a nit:

> LayoutTests/fast/workers/resources/worker-script-error-bubbled.js:7
>      return true;

There is unbalanced ' in the output this line produces.
Comment 3 David Levin 2011-06-20 13:56:09 PDT
(In reply to comment #2)
> (From update of attachment 97853 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97853&action=review
> 
> r=me with a nit:
> 
> > LayoutTests/fast/workers/resources/worker-script-error-bubbled.js:7
> >      return true;
> 
> There is unbalanced ' in the output this line produces.

I don't see it. Perhaps one issue is that both the worker and the main page use ' to quote which is confusing.

I could switch the quotes in the main page to be "" for this message.
Comment 4 Dmitry Titov 2011-06-20 13:59:07 PDT
(In reply to comment #3)
> > There is unbalanced ' in the output this line produces.
> 
> I don't see it. Perhaps one issue is that both the worker and the main page use ' to quote which is confusing.

I don't see it now as well. Please disregard my comment. Perhaps indeed using " for main page could be less confusing.
Comment 5 David Levin 2011-06-20 14:34:25 PDT
Committed as http://trac.webkit.org/changeset/89291.