Bug 62877 - [EFL] Add OwnPtr specializations for EFL types.
Summary: [EFL] Add OwnPtr specializations for EFL types.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 61942 61974 62034
  Show dependency tree / graph
 
Reported: 2011-06-17 10:35 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2011-06-17 11:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.33 KB, patch)
2011-06-17 10:46 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-06-17 10:35:13 PDT 
[EFL] Add OwnPtr specializations for EFL types.
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-06-17 10:46:33 PDT 
Created attachment 97617 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-06-17 10:48:58 PDT 
These specializations are needed for us to upstream EFL's DumpRenderTree, as Eric has been very clear that we should not be doing manual memory management in the code.

The style bot will complain about some struct names, but they are false positives.
Comment 3 Eric Seidel (no email) 2011-06-17 10:50:06 PDT 
Comment on attachment 97617 [details]
Patch

FANTASTIC.  This is the right approach, thank you.
Comment 4 WebKit Review Bot 2011-06-17 10:50:46 PDT 
Attachment 97617 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/OwnPtrCommon.h:54:  Ecore_Evas is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/wtf/OwnPtrCommon.h:55:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Review Bot 2011-06-17 11:58:43 PDT 
Comment on attachment 97617 [details]
Patch

Clearing flags on attachment: 97617

Committed r89153: <http://trac.webkit.org/changeset/89153>
Comment 6 WebKit Review Bot 2011-06-17 11:58:48 PDT 
All reviewed patches have been landed.  Closing bug.