Bug 62877 – [EFL] Add OwnPtr specializations for EFL types.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Raphael Kubo da Costa (:rakuco)]

[EFL] Add OwnPtr specializations for EFL types.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 97617 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

These specializations are needed for us to upstream EFL's DumpRenderTree, as Eric has been very clear that we should not be doing manual memory management in the code.

The style bot will complain about some struct names, but they are false positives.

[Eric Seidel (no email)]

Comment on attachment 97617 [details]
Patch

FANTASTIC.  This is the right approach, thank you.

[WebKit Review Bot]

Attachment 97617 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/OwnPtrCommon.h:54:  Ecore_Evas is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/wtf/OwnPtrCommon.h:55:  Evas_Object is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 97617 [details]
Patch

Clearing flags on attachment: 97617

Committed r89153: <http://trac.webkit.org/changeset/89153>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.