Bug 62868 - Avoid extra work in RenderStyle::visitedDependentColor
Summary: Avoid extra work in RenderStyle::visitedDependentColor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julien Chaffraix
URL: http://code.google.com/p/chromium/iss...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-17 09:20 PDT by Julien Chaffraix
Modified: 2011-06-17 10:37 PDT (History)
2 users (show)

See Also:


Attachments
Proposed fix: refactor the logic of RenderStyle::visitedDependentColor (5.46 KB, patch)
2011-06-17 09:41 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-06-17 09:20:26 PDT
The URL attached URL is a table of 22k rows. Each row has an anchor (a link to the source line for easy copyiing and pasting). When profiling the page, I found out that RenderStyle::visitedColorDependentColor is a hot function accounting for 10% to 15% of the total time. We are calling it too often but this bug is about optimizing the function itself.

Patch forthcoming.
Comment 1 Julien Chaffraix 2011-06-17 09:41:09 PDT
Created attachment 97608 [details]
Proposed fix: refactor the logic of RenderStyle::visitedDependentColor
Comment 2 WebKit Review Bot 2011-06-17 10:35:28 PDT
The commit-queue encountered the following flaky tests while processing attachment 97608 [details]:

http/tests/local/link-stylesheet-load-order.html bug 62878 (author: koivisto@iki.fi)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Review Bot 2011-06-17 10:36:56 PDT
Comment on attachment 97608 [details]
Proposed fix: refactor the logic of RenderStyle::visitedDependentColor

Clearing flags on attachment: 97608

Committed r89142: <http://trac.webkit.org/changeset/89142>
Comment 4 WebKit Review Bot 2011-06-17 10:37:00 PDT
All reviewed patches have been landed.  Closing bug.