Bug 62856 – Web Inspector: use stack trace to create anchors for console messages.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: use stack trace to create anchors for console messages.

So anchors link to exact location in pretty-print mode.

[Pavel Podivilov]

Created attachment 97580 [details]
Patch.

[Yury Semikhatsky]

Comment on attachment 97580 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=97580&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:547
> +        anchor.setAttribute("preferred_panel", "scripts");

You only need to set this once.

> Source/WebCore/inspector/front-end/inspector.js:-1284
> -    node.setAttribute("preferred_panel", preferredPanel);

This code doesn't depend on a particular panel and it'd be better to keep it in a single place instead of repeating it in each panel. Please revert this piece.

[WebKit Review Bot]

Comment on attachment 97580 [details]
Patch.

Attachment 97580 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8877558

New failing tests:
inspector/console/console-eval-scoped.html

[WebKit Review Bot]

Created attachment 97585 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Yury Semikhatsky]

Comment on attachment 97580 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=97580&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:787
> +            var urlElement = WebInspector.linkifyCallFrameAsNode(this._stackTrace[0], "console-message-url");

using this.url and this.line should work equally well, what's the point in using top frame here?

[Pavel Podivilov]

(In reply to comment #2)
> (From update of attachment 97580 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97580&action=review
> 
> > Source/WebCore/inspector/front-end/ScriptsPanel.js:547
> > +        anchor.setAttribute("preferred_panel", "scripts");
> 
> You only need to set this once.

Could you please clarify?

> 
> > Source/WebCore/inspector/front-end/inspector.js:-1284
> > -    node.setAttribute("preferred_panel", preferredPanel);
> 
> This code doesn't depend on a particular panel and it'd be better to keep it in a single place instead of repeating it in each panel. Please revert this piece.

It depends on a particular panel. Default panel is resources panel and it is set by createAnchor in Panel.js. Overrided createAnchor in ScriptsPanel may change it if scripts panel indeed can show anchor location.

> using this.url and this.line should work equally well, what's the point in using top frame here?
We also need column number here to provide accurate mapping in pretty-print mode.

[Pavel Podivilov]

Created attachment 97587 [details]
Build fix.

[Pavel Podivilov]

Committed r89415: <http://trac.webkit.org/changeset/89415>