WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
62844
Added some write barrier action, compiled out by default
https://bugs.webkit.org/show_bug.cgi?id=62844
Summary
Added some write barrier action, compiled out by default
Geoffrey Garen
Reported
2011-06-16 23:02:41 PDT
Added some write barrier action, compiled out by default
Attachments
Patch
(17.08 KB, patch)
2011-06-16 23:06 PDT
,
Geoffrey Garen
no flags
Details
Formatted Diff
Diff
Patch
(17.71 KB, patch)
2011-06-16 23:40 PDT
,
Geoffrey Garen
oliver
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Geoffrey Garen
Comment 1
2011-06-16 23:06:22 PDT
Created
attachment 97546
[details]
Patch
Geoffrey Garen
Comment 2
2011-06-16 23:40:50 PDT
Created
attachment 97548
[details]
Patch
WebKit Review Bot
Comment 3
2011-06-17 03:46:14 PDT
Comment on
attachment 97548
[details]
Patch
Attachment 97548
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/8876547
Oliver Hunt
Comment 4
2011-06-17 08:59:49 PDT
Comment on
attachment 97548
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=97548&action=review
r=me, if you turn off the flag that actually makes these things compiled out :D
> Source/JavaScriptCore/wtf/Platform.h:1211 > +#define ENABLE_GGC 1
Don't you want this off?
Geoffrey Garen
Comment 5
2011-06-17 11:41:07 PDT
> Don't you want this off?
Yes :). Just needed to get the EWS bot to show me the Windows symbol name.
Geoffrey Garen
Comment 6
2011-06-17 12:11:49 PDT
Committed
r89156
: <
http://trac.webkit.org/changeset/89156
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug