Bug 62844 - Added some write barrier action, compiled out by default
Summary: Added some write barrier action, compiled out by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 23:02 PDT by Geoffrey Garen
Modified: 2011-06-17 12:11 PDT (History)
2 users (show)

See Also:


Attachments
Patch (17.08 KB, patch)
2011-06-16 23:06 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (17.71 KB, patch)
2011-06-16 23:40 PDT, Geoffrey Garen
oliver: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-06-16 23:02:41 PDT
Added some write barrier action, compiled out by default
Comment 1 Geoffrey Garen 2011-06-16 23:06:22 PDT
Created attachment 97546 [details]
Patch
Comment 2 Geoffrey Garen 2011-06-16 23:40:50 PDT
Created attachment 97548 [details]
Patch
Comment 3 WebKit Review Bot 2011-06-17 03:46:14 PDT
Comment on attachment 97548 [details]
Patch

Attachment 97548 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8876547
Comment 4 Oliver Hunt 2011-06-17 08:59:49 PDT
Comment on attachment 97548 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97548&action=review

r=me, if you turn off the flag that actually makes these things compiled out :D

> Source/JavaScriptCore/wtf/Platform.h:1211
> +#define ENABLE_GGC 1

Don't you want this off?
Comment 5 Geoffrey Garen 2011-06-17 11:41:07 PDT
> Don't you want this off?

Yes :). Just needed to get the EWS bot to show me the Windows symbol name.
Comment 6 Geoffrey Garen 2011-06-17 12:11:49 PDT
Committed r89156: <http://trac.webkit.org/changeset/89156>