Bug 62843 - WebKit Mac API calls didReceiveAuthenticationChallenge instead of didCancelAuthenticationChallenge
Summary: WebKit Mac API calls didReceiveAuthenticationChallenge instead of didCancelAu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 22:51 PDT by Andrew Wellington
Modified: 2011-06-18 14:04 PDT (History)
1 user (show)

See Also:

Attachments
Proposed fix (1.67 KB, patch)
2011-06-16 22:53 PDT, Andrew Wellington 		no flags Details | Formatted Diff | Diff
Fix tabs in ChangeLog (1.69 KB, patch)
2011-06-16 23:01 PDT, Andrew Wellington 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wellington 2011-06-16 22:51:12 PDT 
WebKit Mac incorrectly calls webView:resource:didReceiveAuthenticationChallenge:fromDataSource: on WebResourceLoadDelegate instead of webView:resource:didCancelAuthenticationChallenge:fromDataSource:

This appears to have been broken for a long long time, since r17396.
Comment 1 Andrew Wellington 2011-06-16 22:53:47 PDT 
Created attachment 97543 [details]
Proposed fix
Comment 2 WebKit Review Bot 2011-06-16 22:55:30 PDT 
Attachment 97543 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/mac/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit/mac/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit/mac/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andrew Wellington 2011-06-16 23:01:01 PDT 
Created attachment 97544 [details]
Fix tabs in ChangeLog
Comment 4 WebKit Review Bot 2011-06-18 14:04:55 PDT 
Comment on attachment 97544 [details]
Fix tabs in ChangeLog

Clearing flags on attachment: 97544

Committed r89207: <http://trac.webkit.org/changeset/89207>
Comment 5 WebKit Review Bot 2011-06-18 14:04:59 PDT 
All reviewed patches have been landed.  Closing bug.