In vertical writing modes, left and right arrow keys move carets up and down, and up and down arrow keys move carets left and right.
Created attachment 97656 [details] work in progress
Created attachment 97661 [details] fixes the bug
I have to admit this is not the prettiest patch I've submitted but don't know a cleaner way of implementing this feature.
Ping reviewers
Comment on attachment 97661 [details] fixes the bug This seems awkward. The flag name is precise, but mechanical. Seems like readers will understand the other arguments to modify and be puzzled by this one. The concept of “swapping” is not quite the right way to describe the fact that turning things 90 degrees might change what the direction means. Despite all of that I have no specific better suggestion, so r=me
(In reply to comment #5) > (From update of attachment 97661 [details]) > This seems awkward. The flag name is precise, but mechanical. Seems like readers will understand the other arguments to modify and be puzzled by this one. The concept of “swapping” is not quite the right way to describe the fact that turning things 90 degrees might change what the direction means. I know. I spent some time thinking about this (tired TreatLineAndCharacterLogically vs. TreatLineAndCharacterPhysically, LineAndCharacterAreLogical vs. LineAndCharacterArePhysical, RespectWritingMode vs. DoNotRespectWritingMode) but couldn't come up with a better name.
It seems like ap thinks it's better to keep 'left', 'character' move the caret visually to the left if I understand him correctly. I'll wait few more days before landing this patch to see if there are any other objections on the whatwg thread titled "getSelection().modify() in vertical writing modes".
I think he’s right. We don’t need a concrete term like “left” to mean “backwards”, when we already have an abstract term for backwards.
This patch has been sitting on the commit queue for a while. I'd like to land this patch unless someone objects. It's really bad to leave the caret movement broken.
I still think that we shouldn't repurpose "left" to mean something other than left.
(In reply to comment #10) > I still think that we shouldn't repurpose "left" to mean something other than left. But 'left' already means up when combined with 'line'. I don't think this patch introduces any confusion than there already is.