Bug 62831 – [Chromium] Add WebDocument APIs for the functions moving from WebFrame

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

[Chromium] Add WebDocument APIs for the functions moving from WebFrame

[Adam Barth]

Created attachment 97516 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 97516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97516&action=review

> Source/WebCore/dom/Document.cpp:3952
> +    // FIXME: Why do only top-level frames have openSearchDescriptionURLs?

If this condition matters to Chromium, then I think we should move it to Chromium.
It definitely doesn't make sense here.

> Source/WebCore/dom/Document.cpp:3956
> +    // FIXME: Why do we need to wait for FrameStateComplete?

I don't know the history of this check, but if Chromium cares to know the loading state before querying this field,
then that also seems like something Chromium should do on its own.

[Adam Barth]

When I move the callers of the APIs over to the new location, I'll get to look at all of them and that will give us a good sense for whether / how to lift these restrictions.

[Darin Fisher (:fishd, Google)]

OK... you might also consider keeping the restrictions in WebDocument.cpp since they seem at best a Chromium specific quirk.

[Adam Barth]

Comment on attachment 97516 [details]
Patch

Ok.  Will do before landing.

[Adam Barth]

Comment on attachment 97516 [details]
Patch

Chromium try job success.

[WebKit Review Bot]

The commit-queue encountered the following flaky tests while processing attachment 97516 [details]:

fast/filesystem/filesystem-uri-origin.html bug 63206 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

Comment on attachment 97516 [details]
Patch

Clearing flags on attachment: 97516

Committed r89504: <http://trac.webkit.org/changeset/89504>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.