Bug 6283 - abstract frame traversal in WebFrame more
Summary: abstract frame traversal in WebFrame more
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
Depends on:
Reported: 2005-12-29 04:27 PST by Maciej Stachowiak
Modified: 2005-12-29 23:10 PST (History)
0 users

See Also:

the patch (30.25 KB, patch)
2005-12-29 04:36 PST, Maciej Stachowiak
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2005-12-29 04:27:29 PST
I rewrote most of the frame traversal code in WebFrame to use DOM-style first/last/next/previous 
methods, to abstract access better in preparation for moving it down. As an added bonus, many formerly 
recursive methods are now iterative. Patch coming shortly.
Comment 1 Maciej Stachowiak 2005-12-29 04:36:51 PST
Created attachment 5350 [details]
the patch
Comment 2 Darin Adler 2005-12-29 08:56:52 PST
Comment on attachment 5350 [details]
the patch

_closeOldDataSources now works from the first child to the last, but it used to
work from the last child to the first.

Looks fine, r=me.
Comment 3 Maciej Stachowiak 2005-12-29 15:40:06 PST
I don't think the order is important since all it does is send a delegate message