Bug 62827 - /msg sheriffbot should work
Summary: /msg sheriffbot should work
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 14:59 PDT by WebKit Review Bot
Modified: 2011-10-13 16:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.65 KB, patch)
2011-06-22 18:01 PDT, Adam Barth 		abarth: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-06-16 14:59:00 PDT 
/msg sheriffbot should work
Requested by smfr on #webkit.
Comment 1 Simon Fraser (smfr) 2011-06-16 14:59:29 PDT 
/msg sheriffbot help should "just work"
Comment 2 Adam Barth 2011-06-16 15:01:31 PDT 
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/irc/ircbot.py#L74

We probably need to override on_privmsg as well as on_pubmsg (or something like that).
Comment 3 Joseph Pecoraro 2011-06-22 17:39:34 PDT 
+1
Comment 4 Adam Barth 2011-06-22 18:01:40 PDT 
Created attachment 98276 [details]
Patch
Comment 5 Eric Seidel (no email) 2011-06-22 18:19:09 PDT 
Comment on attachment 98276 [details]
Patch

I like that you can only talk to him in public.  rollouts, for example, should be a public experience, no?
Comment 6 Eric Seidel (no email) 2011-06-22 18:20:59 PDT 
I agree that he shouldn't just ignore private messages.  I'm just not sure if we should allow commands in private?  But maybe I'm naive.
Comment 7 Simon Fraser (smfr) 2011-06-22 18:31:32 PDT 
'help' should work in private. 'create-bug' is OK. Not sure about others.
Comment 8 Adam Barth 2011-07-11 12:14:59 PDT 
Comment on attachment 98276 [details]
Patch

I think Eric meant to R- this patch.
Comment 9 Adam Barth 2011-10-13 16:10:57 PDT 
Having some functions but not others work in private is too complicated.  Having things in public seems fine.  That helps me understand how folks use the tool.