RESOLVED WONTFIX 62827
/msg sheriffbot should work 
https://bugs.webkit.org/show_bug.cgi?id=62827
Summary /msg sheriffbot should work
WebKit Review Bot
Reported 2011-06-16 14:59:00 PDT
/msg sheriffbot should work Requested by smfr on #webkit.
Attachments
Patch (2.65 KB, patch)
2011-06-22 18:01 PDT, Adam Barth 		abarth: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-06-16 14:59:29 PDT
/msg sheriffbot help should "just work"
Adam Barth
Comment 2 2011-06-16 15:01:31 PDT
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/irc/ircbot.py#L74 We probably need to override on_privmsg as well as on_pubmsg (or something like that).
Joseph Pecoraro
Comment 3 2011-06-22 17:39:34 PDT
+1
Adam Barth
Comment 4 2011-06-22 18:01:40 PDT
Created attachment 98276 [details] Patch
Eric Seidel (no email)
Comment 5 2011-06-22 18:19:09 PDT
Comment on attachment 98276 [details] Patch I like that you can only talk to him in public. rollouts, for example, should be a public experience, no?
Eric Seidel (no email)
Comment 6 2011-06-22 18:20:59 PDT
I agree that he shouldn't just ignore private messages. I'm just not sure if we should allow commands in private? But maybe I'm naive.
Simon Fraser (smfr)
Comment 7 2011-06-22 18:31:32 PDT
'help' should work in private. 'create-bug' is OK. Not sure about others.
Adam Barth
Comment 8 2011-07-11 12:14:59 PDT
Comment on attachment 98276 [details] Patch I think Eric meant to R- this patch.
Adam Barth
Comment 9 2011-10-13 16:10:57 PDT
Having some functions but not others work in private is too complicated. Having things in public seems fine. That helps me understand how folks use the tool.
Note You need to log in before you can comment on or make changes to this bug.