Bug 62824 - DFG JIT - add support for branch-fusion of compareEq, JSValue comparisons in SpeculativeJIT
Summary: DFG JIT - add support for branch-fusion of compareEq, JSValue comparisons in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 14:46 PDT by Gavin Barraclough
Modified: 2011-06-16 16:40 PDT (History)
0 users

See Also:


Attachments
The patch (7.96 KB, patch)
2011-06-16 14:48 PDT, Gavin Barraclough
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-06-16 14:46:25 PDT
CompareEq of non-integer values is the most common cause of speculation failure.
Comment 1 Gavin Barraclough 2011-06-16 14:48:44 PDT
Created attachment 97507 [details]
The patch
Comment 2 Sam Weinig 2011-06-16 15:18:12 PDT
Comment on attachment 97507 [details]
The patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97507&action=review

> Source/JavaScriptCore/ChangeLog:16
> +        * dfg/DFGSpeculativeJIT.cpp:
> +        (JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
> +        (JSC::DFG::SpeculativeJIT::compilePeepHoleEq):
> +        (JSC::DFG::SpeculativeJIT::compile):
> +        * dfg/DFGSpeculativeJIT.h:
> +        (JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
> +        (JSC::DFG::SpeculativeJIT::isInteger):

PLease add data :(
Comment 3 Gavin Barraclough 2011-06-16 16:40:26 PDT
Fixed in r89084