Bug 62823 – convert editing/deleting/delete-3608430-fix.html to DumpAsTextEditingTest

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wyatt Carss]

If possible, I'd like to find out what this test is actually testing. I'm reviewing possible candidates for conversion to text, and this one's very opaque, but doesn't appear to need to be rendered.

It also happens to have a broken image reference and a superfluous quote floating in it - after fixing them, the test still passed. My hypothesis is that it's testing that deleting an image will remove the empty <i></i> before it, so with a certain number of deletion operations we'll end up with a certain success text. In that case, the progression of operations and the success text matter more than the pixels, so DumpAsTextEditingTest seems like a great choice. But I'm concerned that there's something I'm missing here -- also, I'd love to add a self-contained description to the test for the future.

[Wyatt Carss]

Created attachment 97508 [details]
possible patch

[Wyatt Carss]

Comment on attachment 97508 [details]
possible patch

If this description is correct, and there aren't objections to conversion, I submit this patch. Otherwise, I'll make corrections.

[Ryosuke Niwa]

Comment on attachment 97508 [details]
possible patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97508&action=review

> LayoutTests/editing/deleting/delete-3608430-fix.html:37
> -runEditingTest();
> +runDumpAsTextEditingTest();

We might need to wait until page load event because the image may not have been loaded at this point.

[WebKit Review Bot]

Comment on attachment 97508 [details]
possible patch

Clearing flags on attachment: 97508

Committed r89382: <http://trac.webkit.org/changeset/89382>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.