Bug 62798 - MediaStream API: Runtime enabled features
Summary: MediaStream API: Runtime enabled features
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency treegraph
 
Reported: 2011-06-16 08:08 PDT by Tommy Widenflycht
Modified: 2011-06-16 09:20 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.46 KB, patch)
2011-06-16 08:13 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (3.41 KB, patch)
2011-06-16 08:22 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (3.63 KB, patch)
2011-06-16 08:26 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2011-06-16 08:08:12 PDT
Add the WebRuntimeFeatures API and enable the feature by default in DumpRenderTree.
Comment 1 Tommy Widenflycht 2011-06-16 08:13:12 PDT
Created attachment 97443 [details]
Patch
Comment 2 Tony Gentilcore 2011-06-16 08:17:21 PDT
Comment on attachment 97443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97443&action=review

Just fix up the changelog and i'll cq+ this.

> Source/WebKit/chromium/ChangeLog:5
> +        WebRuntimeFeatures

Stray diff? Extra ChangeLog information should go below the title and bug link.

Also, you should add at least a sentence about what this patch does.
Comment 3 Tommy Widenflycht 2011-06-16 08:22:02 PDT
Created attachment 97445 [details]
Patch
Comment 4 Tommy Widenflycht 2011-06-16 08:23:48 PDT
Comment on attachment 97443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97443&action=review

>> Source/WebKit/chromium/ChangeLog:5
>> +        WebRuntimeFeatures
> 
> Stray diff? Extra ChangeLog information should go below the title and bug link.
> 
> Also, you should add at least a sentence about what this patch does.

Sorry about that, will fix properly this time.
Comment 5 Tommy Widenflycht 2011-06-16 08:26:39 PDT
Created attachment 97447 [details]
Patch
Comment 6 Leandro Graciá Gil 2011-06-16 08:29:24 PDT
If you've checked it works this looks good to me.
Comment 7 WebKit Review Bot 2011-06-16 09:20:05 PDT
Comment on attachment 97447 [details]
Patch

Clearing flags on attachment: 97447

Committed r89032: <http://trac.webkit.org/changeset/89032>
Comment 8 WebKit Review Bot 2011-06-16 09:20:09 PDT
All reviewed patches have been landed.  Closing bug.