Bug 62793 - Add a function hasRenderer()
Summary: Add a function hasRenderer()
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Roland Steiner
URL:
Keywords:
Depends on: 62333
Blocks: 72352
  Show dependency treegraph
 
Reported: 2011-06-16 03:57 PDT by Roland Steiner
Modified: 2012-05-28 23:32 PDT (History)
9 users (show)

See Also:


Attachments
Patch (200.51 KB, patch)
2011-06-16 04:24 PDT, Roland Steiner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2011-06-16 03:57:46 PDT
Currently, the function renderer() is used to both retrieve a node's renderer, as well as to simply check for the presence of a renderer (implicitly converting to bool).

For future implementation changes, notably around SVG shadow tree implementations, separating the latter use-case out into a new function hasRenderer() would be helpful.
Comment 1 Roland Steiner 2011-06-16 04:24:46 PDT
Created attachment 97435 [details]
Patch
Comment 2 WebKit Review Bot 2011-06-16 04:27:23 PDT
Attachment 97435 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/editing/ReplaceSelectionCommand.cpp:151:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 111 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dimitri Glazkov (Google) 2011-06-16 08:41:37 PDT
Rob, Niko, Dirk -- this is a nice exploration of how much work we have ahead of us on making RenderObject multiplex on Node.
Comment 4 Dimitri Glazkov (Google) 2011-06-16 08:42:02 PDT
Comment on attachment 97435 [details]
Patch

Removing r?, since this is just an exploration at the moment.
Comment 5 Alexey Proskuryakov 2011-06-16 10:09:55 PDT
> For future implementation changes, notably around SVG shadow tree implementations, separating the latter use-case out into a new function hasRenderer() would be helpful.

Does this mean that non-null renderer() result will not be equivalent to hasRenderer() returning true?
Comment 6 Hajime Morrita 2012-05-28 23:32:17 PDT
Closing - we have no concrete plan which relies on this.