WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 62767
Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
https://bugs.webkit.org/show_bug.cgi?id=62767
Summary
Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-b...
Daniel Bates
Reported
2011-06-15 17:45:16 PDT
We should add a remark about the optional --skip-build argument to the usage message of run-javascriptcore-tests.
Attachments
Patch
(1.24 KB, patch)
2011-06-15 17:47 PDT
,
Daniel Bates
eric
: review+
Details
Formatted Diff
Diff
Patch
(5.32 KB, patch)
2011-06-16 10:07 PDT
,
Daniel Bates
eric
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2011-06-15 17:47:26 PDT
Created
attachment 97379
[details]
Patch
Eric Seidel (no email)
Comment 2
2011-06-15 17:59:15 PDT
Comment on
attachment 97379
[details]
Patch Is that how the arg is named for run-webkit-tests? I feel like we must have this sort of arg elsewhere.
Daniel Bates
Comment 3
2011-06-15 18:32:42 PDT
(In reply to
comment #2
)
> (From update of
attachment 97379
[details]
) > Is that how the arg is named for run-webkit-tests? I feel like we must have this sort of arg elsewhere.
Both old-run-webkit-tests and run-webkit-tests.py have a --no-build option which is analogous to --skip-build. Note, for old-run-webkit-tests this option isn't listed in its usage message. We should add it. For consistency, we should either chose to use --skip-build or --no-build. Note, to change run-javascriptcore-tests to use the latter we'll need to modify the buildbot configuration which references --skip-build.
Daniel Bates
Comment 4
2011-06-16 10:07:37 PDT
Created
attachment 97456
[details]
Patch Rename --skip-build to --no-build to be consistent with the option of the same name in run-webkit-tests. We should follow up and add a build option to old-run-webkit-tests (it only has --no-build, but new-run-webkit-tests also has a --build option). We should also add the --no-build option to the usage message for old-run-webkit-tests.
Eric Seidel (no email)
Comment 5
2011-06-16 10:11:00 PDT
Comment on
attachment 97456
[details]
Patch OK. This will require a master restart.
Daniel Bates
Comment 6
2011-06-17 08:08:34 PDT
As discussed with Eric Seidel on IRC yesterday (06/16/2011), I'm going to land this in three parts. Part 1 will add the --build/--no-build option to run-javascriptcore-tests. Part 2 will change the buildbot master config. Part 3 will remove the --skip-build option from run-javascriptcore-tests once the master buildbot pick up this configuration.
Daniel Bates
Comment 7
2011-06-17 08:34:58 PDT
Committed part 1 in changeset 89136 <
http://trac.webkit.org/changeset/89136
>. Comitted buildbot master.cfg (part 2) in changeset 89138 <
http://trac.webkit.org/changeset/89138
>.
William Siegrist
Comment 8
2011-06-17 08:38:41 PDT
Master updated.
Ryosuke Niwa
Comment 9
2011-06-17 15:53:23 PDT
It seems unit tests are failing to build after this patch was landed:
http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/713
Running build-api-tests Compiling TestWebKitAPI failed! program finished with exit code 1 elapsedTime=24.968663
Daniel Bates
Comment 10
2011-06-17 16:02:43 PDT
(In reply to
comment #9
)
> It seems unit tests are failing to build after this patch was landed: >
http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/713
> > Running build-api-tests > Compiling TestWebKitAPI failed! > program finished with exit code 1 > elapsedTime=24.968663
It's unclear to me why. I mean, we shouldn't be compiling such API tests for GTK. I filed <
https://bugs.webkit.org/show_bug.cgi?id=62892
> for this.
Daniel Bates
Comment 11
2011-06-17 16:41:48 PDT
(In reply to
comment #9
)
> It seems unit tests are failing to build after this patch was landed: >
http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/713
> I misread, this is also failing on the Snow Leopard Debug build machine. In order to roll this out we need to roll out
r89138
, restart the buildbot master and then roll out
r89136
. Using a debug build of
r89139
, I was able to successfully run build-api-tests --debug (which is called by run-api-tests) on Mac OS 10.6.7. For some reason the Snow Leopard Debug bot just calls build-api-tests (without the --debug flag).
Daniel Bates
Comment 12
2011-06-17 17:14:45 PDT
(In reply to
comment #11
)
> For some reason the Snow Leopard Debug bot just calls build-api-tests (without the --debug flag).
Support for running unit tests was added to the build bot master config as part of
bug #62603
. Notice, the patch will make the bot always calls run-api-tests (without the --debug argument). Hence, the bot will attempt a release build, but this fails since the bot has a debug build.
Daniel Bates
Comment 13
2011-06-17 17:23:30 PDT
(In reply to
comment #12
)
> (In reply to
comment #11
) > > For some reason the Snow Leopard Debug bot just calls build-api-tests (without the --debug flag). > > Support for running unit tests was added to the build bot master config as part of
bug #62603
. Notice, the patch will make the bot always calls run-api-tests (without the --debug argument). Hence, the bot will attempt a release build, but this fails since the bot has a debug build.
See
bug #62918
for more details.
Daniel Bates
Comment 14
2011-06-18 17:51:33 PDT
Committed part 3 (removal of --skip-build option) in changeset 89208 <
http://trac.webkit.org/changeset/89208
>.
William Siegrist
Comment 15
2011-06-19 11:17:33 PDT
Master updated.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug