Bug 62756 - Clarify FileChooser creation code.
Summary: Clarify FileChooser creation code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 62069
  Show dependency treegraph
 
Reported: 2011-06-15 14:28 PDT by Dimitri Glazkov (Google)
Modified: 2011-06-15 17:55 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.27 KB, patch)
2011-06-15 14:31 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-06-15 14:28:49 PDT
Clarify FileChooser creation code.
Comment 1 Dimitri Glazkov (Google) 2011-06-15 14:31:20 PDT
Created attachment 97364 [details]
Patch
Comment 2 Adam Barth 2011-06-15 14:32:06 PDT
Comment on attachment 97364 [details]
Patch

Even I can see that this change is correct.
Comment 3 WebKit Review Bot 2011-06-15 15:12:04 PDT
Comment on attachment 97364 [details]
Patch

Clearing flags on attachment: 97364

Committed r88977: <http://trac.webkit.org/changeset/88977>
Comment 4 WebKit Review Bot 2011-06-15 15:12:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2011-06-15 17:45:57 PDT
Comment on attachment 97364 [details]
Patch

Why not fold it into the constructor? We don't usually do anything besides new+adopt in create() functions.
Comment 6 Dimitri Glazkov (Google) 2011-06-15 17:55:07 PDT
(In reply to comment #5)
> (From update of attachment 97364 [details])
> Why not fold it into the constructor? We don't usually do anything besides new+adopt in create() functions.

loadIcon refs FileChooser and that can be a bad, bad thing. We even ASSERT about it in RefCounted.