Clarify FileChooser creation code.
Created attachment 97364 [details] Patch
Comment on attachment 97364 [details] Patch Even I can see that this change is correct.
Comment on attachment 97364 [details] Patch Clearing flags on attachment: 97364 Committed r88977: <http://trac.webkit.org/changeset/88977>
All reviewed patches have been landed. Closing bug.
Comment on attachment 97364 [details] Patch Why not fold it into the constructor? We don't usually do anything besides new+adopt in create() functions.
(In reply to comment #5) > (From update of attachment 97364 [details]) > Why not fold it into the constructor? We don't usually do anything besides new+adopt in create() functions. loadIcon refs FileChooser and that can be a bad, bad thing. We even ASSERT about it in RefCounted.