Bug 62748 - Move FileChooser::basenameForWidth to RenderTheme::fileListNameForWidth, eliminate gnarly FileChooserFoo proliferation.
Summary: Move FileChooser::basenameForWidth to RenderTheme::fileListNameForWidth, elim...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 62069
  Show dependency treegraph
 
Reported: 2011-06-15 12:50 PDT by Dimitri Glazkov (Google)
Modified: 2011-06-16 10:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (50.10 KB, patch)
2011-06-15 12:54 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
Let's cook this on bots. (49.74 KB, patch)
2011-06-15 13:15 PDT, Dimitri Glazkov (Google)
tkent: review+
dglazkov: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-06-15 12:50:20 PDT
Move FileChooser::basenameForWidth to RenderTheme::fileListNameForWidth, eliminate gnarly FileChooserFoo proliferation.
Comment 1 Dimitri Glazkov (Google) 2011-06-15 12:54:55 PDT
Created attachment 97349 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-06-15 12:55:56 PDT
Need to cook on bots.
Comment 3 Dimitri Glazkov (Google) 2011-06-15 13:01:19 PDT
Comment on attachment 97349 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97349&action=review

> Source/WebCore/platform/qt/RenderThemeQt.cpp:189
> +    QApplication defaultButtonFont = QApplication::font(&button);

GAH! Didn't mean that.
Comment 4 Dimitri Glazkov (Google) 2011-06-15 13:15:42 PDT
Created attachment 97352 [details]
Let's cook this on bots.
Comment 5 Dimitri Glazkov (Google) 2011-06-15 13:41:29 PDT
Comment on attachment 97352 [details]
Let's cook this on bots.

I am optimistic.
Comment 6 Kent Tamura 2011-06-15 18:12:23 PDT
Comment on attachment 97352 [details]
Let's cook this on bots.

Qt EWS and EFL EWS don't work for now.  Please pay attention when you land this.
Comment 7 Dimitri Glazkov (Google) 2011-06-16 10:33:27 PDT
Committed r89039: <http://trac.webkit.org/changeset/89039>