Bug 62747 - Try to use fastGetAttribute where possible
Summary: Try to use fastGetAttribute where possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 12:39 PDT by Rob Buis
Modified: 2011-06-15 18:54 PDT (History)
1 user (show)

See Also:


Attachments
Patch (32.93 KB, patch)
2011-06-15 13:17 PDT, Rob Buis
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2011-06-15 12:39:22 PDT
From the comment in Element.h:

    // Call this to get the value of an attribute that is known not to be the style
    // attribute or one of the SVG animatable attributes.
    bool fastHasAttribute(const QualifiedName&) const;
    const AtomicString& fastGetAttribute(const QualifiedName&) const;

There are places in SVG where we do not need to call getAttribute but can use fastGetAttribute, fix that.
Comment 1 Rob Buis 2011-06-15 13:17:06 PDT
Created attachment 97353 [details]
Patch
Comment 2 Rob Buis 2011-06-15 18:54:55 PDT
Committed r88989: <http://trac.webkit.org/changeset/88989>