Bug 62744 - [Qt] enable icu build not work
Summary: [Qt] enable icu build not work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: qi
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-06-15 12:11 PDT by qi
Modified: 2011-06-17 02:33 PDT (History)
7 users (show)

See Also:


Attachments
patch (1.15 KB, patch)
2011-06-15 12:21 PDT, qi
no flags Details | Formatted Diff | Diff
patch2 (1.04 KB, patch)
2011-06-16 07:27 PDT, qi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description qi 2011-06-15 12:11:08 PDT
enable icu build not work
Comment 1 qi 2011-06-15 12:21:57 PDT
Created attachment 97342 [details]
patch

See https://bugs.webkit.org/attachment.cgi?bugid=60786, which define use_system_icu to enable WTF_USE_QT4_UNICODE or WTF_USE_ICU_UNICODE. But in Platform.h we still keep the default flag to enable WTF_USE_QT4_UNICODE, which means when we use use_system_icu, actually both of them will be enabled.
Comment 2 Laszlo Gombos 2011-06-16 06:22:53 PDT
Comment on attachment 97342 [details]
patch

I prefer to keep these rules in the source code and not in the build system. Instead of removing this from the source code, can we do the following ?

#ifndef WTF_USE_ICU_UNICODE
#define WTF_USE_QT4_UNICODE 1
#endif
Comment 3 qi 2011-06-16 07:27:02 PDT
Created attachment 97441 [details]
patch2

Renew the patch.
Comment 4 Laszlo Gombos 2011-06-16 09:13:14 PDT
Comment on attachment 97441 [details]
patch2

Looks good to me. Thanks.
Comment 5 WebKit Review Bot 2011-06-16 09:56:09 PDT
Comment on attachment 97441 [details]
patch2

Clearing flags on attachment: 97441

Committed r89037: <http://trac.webkit.org/changeset/89037>
Comment 6 WebKit Review Bot 2011-06-16 09:56:13 PDT
All reviewed patches have been landed.  Closing bug.