Bug 62740 - documentDidBecomeActive() is called twice for pages being restored from the page cache
Summary: documentDidBecomeActive() is called twice for pages being restored from the p...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 11:21 PDT by Simon Fraser (smfr)
Modified: 2022-08-20 16:29 PDT (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-06-15 11:21:58 PDT 
FrameLoader::commitProvisionalLoad() calls cachedPage->restore(m_frame->page()); which calls documentDidBecomeActive(). It then calls m_frame->document()->documentDidBecomeActive() a second time lower down.
Comment 1 Ahmad Saleem 2022-08-13 06:06:16 PDT 
https://github.com/WebKit/WebKit/blob/7de67f9a0ccc4fc8ce195e32f61e7873ad81345e/Source/WebCore/loader/FrameLoader.cpp#L2016

Is this needed now or this logic has been reworked? Thanks!