These tests would run correctly if we used execCommand(insertParagraph) instead of eventSender('\n')
Created attachment 97337 [details] Patch
(In reply to comment #1) > Created an attachment (id=97337) [details] > Patch Note on this patch: switching to execCommand(insertParagraph) resulted in an extra newline being added in return-key-in-hidden-field. I am not sure if this is okay, or if I have changed the behavior of the test too much. Also, the qt platform has its own expected results file (which has one more newline than the original). Not sure how to check if it needs to be updated (I only have a mac to test on locally)
Comment on attachment 97337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97337&action=review > LayoutTests/editing/inserting/return-key-in-hidden-field-expected.txt:6 > + Interesting to see extra line added here. Maybe because we're in standard mode now?
cq?
I'd like to put this patch in the commit queue, but I won't be able to watch it while I am at the conference. Should we wait till I get back in the office on Friday?
(In reply to comment #3) > Interesting to see extra line added here. Maybe because we're in standard mode now? I tried deleting <!DOCTYPE html> and got the same result.
(In reply to comment #5) > I'd like to put this patch in the commit queue, but I won't be able to watch it while I am at the conference. Should we wait till I get back in the office on Friday? That sounds good to me.
Comment on attachment 97337 [details] Patch Clearing flags on attachment: 97337 Committed r89149: <http://trac.webkit.org/changeset/89149>
All reviewed patches have been landed. Closing bug.