Bug 62722 - Unskip passing tests what needs layoutTestController.clearBackForwardList
Summary: Unskip passing tests what needs layoutTestController.clearBackForwardList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 06:06 PDT by Fehér Zsolt
Modified: 2011-06-18 21:45 PDT (History)
6 users (show)

See Also:


Attachments
Diff (2.17 KB, patch)
2011-06-15 06:07 PDT, Fehér Zsolt
ossy: review-
ossy: commit-queue-
Details | Formatted Diff | Diff
Diff (2.37 KB, patch)
2011-06-16 03:31 PDT, Fehér Zsolt
ossy: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fehér Zsolt 2011-06-15 06:06:43 PDT
https://bugs.webkit.org/show_bug.cgi?id=42333
Comment 1 Fehér Zsolt 2011-06-15 06:07:33 PDT
Created attachment 97282 [details]
Diff
Comment 2 Csaba Osztrogonác 2011-06-15 08:29:10 PDT
Comment on attachment 97282 [details]
Diff

View in context: https://bugs.webkit.org/attachment.cgi?id=97282&action=review

> LayoutTests/platform/qt-wk2/Skipped:1447
>  # WebKitTestRunner needs layoutTestController.clearBackForwardList
>  # <https://bugs.webkit.org/show_bug.cgi?id=42333>

.

> LayoutTests/platform/qt-wk2/Skipped:1448
>  http/tests/loading/state-object-security-exception.html

r- now, because failing of this test is absolutely unrelated to layoutTestController.clearBackForwardList
Comment 3 Csaba Osztrogonác 2011-06-15 08:41:12 PDT
I filed a new bug report on this fail: https://bugs.webkit.org/show_bug.cgi?id=62731

Please keep this test on the Skipped list with this comment:

# https://bugs.webkit.org/show_bug.cgi?id=62731
# [Qt][WK2] http/tests/loading/state-object-security-exception.html fails
http/tests/loading/state-object-security-exception.html
Comment 4 Fehér Zsolt 2011-06-16 03:31:38 PDT
Created attachment 97431 [details]
Diff
Comment 5 WebKit Review Bot 2011-06-16 03:47:25 PDT
Comment on attachment 97431 [details]
Diff

Rejecting attachment 97431 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 382, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 438, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/8876165
Comment 6 WebKit Review Bot 2011-06-16 03:51:37 PDT
Comment on attachment 97431 [details]
Diff

Rejecting attachment 97431 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 382, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 438, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/8880161
Comment 7 Darin Adler 2011-06-18 12:50:21 PDT
Comment on attachment 97431 [details]
Diff

Lets try one more time.
Comment 8 WebKit Review Bot 2011-06-18 13:28:45 PDT
Comment on attachment 97431 [details]
Diff

Rejecting attachment 97431 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 382, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 438, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/8907007
Comment 9 Eric Seidel (no email) 2011-06-18 20:03:39 PDT
Odd error.
Comment 10 Daniel Bates 2011-06-18 21:34:11 PDT
(In reply to comment #9)
> Odd error.

I'm not sure about the error. On another note, the patch for this bug was committed on 06/16/2011 in changeset 89022 <http://trac.webkit.org/changeset/89022>.
Comment 11 Daniel Bates 2011-06-18 21:45:12 PDT
(In reply to comment #9)
> Odd error.

Filed bug #62948 for this issue.