Bug 62722 – Unskip passing tests what needs layoutTestController.clearBackForwardList

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Fehér Zsolt]

https://bugs.webkit.org/show_bug.cgi?id=42333

[Fehér Zsolt]

Created attachment 97282 [details]
Diff

[Csaba Osztrogonác]

Comment on attachment 97282 [details]
Diff

View in context: https://bugs.webkit.org/attachment.cgi?id=97282&action=review

> LayoutTests/platform/qt-wk2/Skipped:1447
>  # WebKitTestRunner needs layoutTestController.clearBackForwardList
>  # <https://bugs.webkit.org/show_bug.cgi?id=42333>

.

> LayoutTests/platform/qt-wk2/Skipped:1448
>  http/tests/loading/state-object-security-exception.html

r- now, because failing of this test is absolutely unrelated to layoutTestController.clearBackForwardList

[Csaba Osztrogonác]

I filed a new bug report on this fail: https://bugs.webkit.org/show_bug.cgi?id=62731

Please keep this test on the Skipped list with this comment:

# https://bugs.webkit.org/show_bug.cgi?id=62731
# [Qt][WK2] http/tests/loading/state-object-security-exception.html fails
http/tests/loading/state-object-security-exception.html

[Fehér Zsolt]

Created attachment 97431 [details]
Diff

[WebKit Review Bot]

Comment on attachment 97431 [details]
Diff

Rejecting attachment 97431 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 382, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 438, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/8876165

[WebKit Review Bot]

Comment on attachment 97431 [details]
Diff

Rejecting attachment 97431 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 382, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 438, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/8880161

[Darin Adler]

Comment on attachment 97431 [details]
Diff

Lets try one more time.

[WebKit Review Bot]

Comment on attachment 97431 [details]
Diff

Rejecting attachment 97431 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 382, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 438, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/8907007

[Eric Seidel (no email)]

Odd error.

[Daniel Bates]

(In reply to comment #9)
> Odd error.

I'm not sure about the error. On another note, the patch for this bug was committed on 06/16/2011 in changeset 89022 <http://trac.webkit.org/changeset/89022>.

[Daniel Bates]

(In reply to comment #9)
> Odd error.

Filed bug #62948 for this issue.