Currently, we use frame address as a frame id, this does not guarantee frame ids to be unique through the life time of the process. This is first step in making frame ids unique -- we now assign sequential ids and maintain them as a map within InspectorPageAgent. The next step would be to make the ids unique for multi-process browsers by including some system-unique identifier.
Created attachment 97279 [details] patch
Attachment 97279 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorPageAgent.cpp:648: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/inspector/InspectorPageAgent.cpp:653: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/inspector/InspectorPageAgent.cpp:659: Declaration has space between type name and * in Frame *frame [whitespace/declaration] [3] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 97280 [details] patch (style fixed)
Comment on attachment 97280 [details] patch (style fixed) View in context: https://bugs.webkit.org/attachment.cgi?id=97280&action=review > Source/WebCore/inspector/InspectorPageAgent.cpp:646 > +InspectorPageAgent::FrameEntry::FrameEntry() I'd rather instrument frame destruction.
Created attachment 97287 [details] patch (FrameDestructionObserver -> InspectorInstrumentation)
Attachment 97280 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 9 Updating OpenSource RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': timed out waiting for server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295 Died at Tools/Scripts/update-webkit line 146. If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 97287 [details] patch (FrameDestructionObserver -> InspectorInstrumentation) View in context: https://bugs.webkit.org/attachment.cgi?id=97287&action=review > Source/WebCore/inspector/InspectorPageAgent.cpp:594 > + ASSERT(iterator != m_frameToIdentifier.end()); This assertion will fail due to the lazy identifier assignment.
Created attachment 97292 [details] patch Thanks for catching this! This is an unfortunate leftover from the previous implementation.
manually committed r88940: http://trac.webkit.org/changeset/88940