WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
62721
Web Inspector: provide unique identifiers for frames
https://bugs.webkit.org/show_bug.cgi?id=62721
Summary
Web Inspector: provide unique identifiers for frames
Andrey Kosyakov
Reported
2011-06-15 05:45:54 PDT
Currently, we use frame address as a frame id, this does not guarantee frame ids to be unique through the life time of the process. This is first step in making frame ids unique -- we now assign sequential ids and maintain them as a map within InspectorPageAgent. The next step would be to make the ids unique for multi-process browsers by including some system-unique identifier.
Attachments
patch
(5.86 KB, patch)
2011-06-15 05:49 PDT
,
Andrey Kosyakov
no flags
Details
Formatted Diff
Diff
patch (style fixed)
(5.86 KB, patch)
2011-06-15 05:56 PDT
,
Andrey Kosyakov
pfeldman
: review-
Details
Formatted Diff
Diff
patch (FrameDestructionObserver -> InspectorInstrumentation)
(7.48 KB, patch)
2011-06-15 06:40 PDT
,
Andrey Kosyakov
pfeldman
: review-
Details
Formatted Diff
Diff
patch
(7.50 KB, patch)
2011-06-15 07:37 PDT
,
Andrey Kosyakov
pfeldman
: review+
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1
2011-06-15 05:49:06 PDT
Created
attachment 97279
[details]
patch
WebKit Review Bot
Comment 2
2011-06-15 05:53:22 PDT
Attachment 97279
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorPageAgent.cpp:648: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/inspector/InspectorPageAgent.cpp:653: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/inspector/InspectorPageAgent.cpp:659: Declaration has space between type name and * in Frame *frame [whitespace/declaration] [3] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andrey Kosyakov
Comment 3
2011-06-15 05:56:20 PDT
Created
attachment 97280
[details]
patch (style fixed)
Pavel Feldman
Comment 4
2011-06-15 06:04:49 PDT
Comment on
attachment 97280
[details]
patch (style fixed) View in context:
https://bugs.webkit.org/attachment.cgi?id=97280&action=review
> Source/WebCore/inspector/InspectorPageAgent.cpp:646 > +InspectorPageAgent::FrameEntry::FrameEntry()
I'd rather instrument frame destruction.
Andrey Kosyakov
Comment 5
2011-06-15 06:40:22 PDT
Created
attachment 97287
[details]
patch (FrameDestructionObserver -> InspectorInstrumentation)
WebKit Review Bot
Comment 6
2011-06-15 06:57:48 PDT
Attachment 97280
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 9 Updating OpenSource RA layer request failed: OPTIONS of '
http://svn.webkit.org/repository/webkit
': timed out waiting for server (
http://svn.webkit.org
) at /usr/lib/git-core/git-svn line 2295 Died at Tools/Scripts/update-webkit line 146. If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Feldman
Comment 7
2011-06-15 07:19:34 PDT
Comment on
attachment 97287
[details]
patch (FrameDestructionObserver -> InspectorInstrumentation) View in context:
https://bugs.webkit.org/attachment.cgi?id=97287&action=review
> Source/WebCore/inspector/InspectorPageAgent.cpp:594 > + ASSERT(iterator != m_frameToIdentifier.end());
This assertion will fail due to the lazy identifier assignment.
Andrey Kosyakov
Comment 8
2011-06-15 07:37:09 PDT
Created
attachment 97292
[details]
patch Thanks for catching this! This is an unfortunate leftover from the previous implementation.
Andrey Kosyakov
Comment 9
2011-06-15 08:44:44 PDT
manually committed
r88940
:
http://trac.webkit.org/changeset/88940
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug