Bug 62721 – Web Inspector: provide unique identifiers for frames

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

Currently, we use frame address as a frame id, this does not guarantee frame ids to be unique through the life time of the process.
This is first step in making frame ids unique -- we now assign sequential ids and maintain them as a map within InspectorPageAgent.
The next step would be to make the ids unique for multi-process browsers by including some system-unique identifier.

[Andrey Kosyakov]

Created attachment 97279 [details]
patch

[WebKit Review Bot]

Attachment 97279 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorPageAgent.cpp:648:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/inspector/InspectorPageAgent.cpp:653:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/inspector/InspectorPageAgent.cpp:659:  Declaration has space between type name and * in Frame *frame  [whitespace/declaration] [3]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andrey Kosyakov]

Created attachment 97280 [details]
patch (style fixed)

[Pavel Feldman]

Comment on attachment 97280 [details]
patch (style fixed)

View in context: https://bugs.webkit.org/attachment.cgi?id=97280&action=review

> Source/WebCore/inspector/InspectorPageAgent.cpp:646
> +InspectorPageAgent::FrameEntry::FrameEntry()

I'd rather instrument frame destruction.

[Andrey Kosyakov]

Created attachment 97287 [details]
patch (FrameDestructionObserver -> InspectorInstrumentation)

[WebKit Review Bot]

Attachment 97280 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 9

Updating OpenSource
RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': timed out waiting for server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295

Died at Tools/Scripts/update-webkit line 146.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Feldman]

Comment on attachment 97287 [details]
patch (FrameDestructionObserver -> InspectorInstrumentation)

View in context: https://bugs.webkit.org/attachment.cgi?id=97287&action=review

> Source/WebCore/inspector/InspectorPageAgent.cpp:594
> +    ASSERT(iterator != m_frameToIdentifier.end());

This assertion will fail due to the lazy identifier assignment.

[Andrey Kosyakov]

Created attachment 97292 [details]
patch

Thanks for catching this! This is an unfortunate leftover from the previous implementation.

[Andrey Kosyakov]

manually committed r88940: http://trac.webkit.org/changeset/88940