Bug 62713 - [EFL] Implement animationXXX functions for Progress Tag
Summary: [EFL] Implement animationXXX functions for Progress Tag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 03:24 PDT by Gyuyoung Kim
Modified: 2011-06-15 17:37 PDT (History)
9 users (show)

See Also:


Attachments
Proposed Patch (2.62 KB, patch)
2011-06-15 03:28 PDT, Gyuyoung Kim
lucas.de.marchi: review-
lucas.de.marchi: commit-queue-
Details | Formatted Diff | Diff
Patch (3.03 KB, patch)
2011-06-15 08:50 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-06-15 03:24:30 PDT
Progress tag need to implement acnimationXXX functions in order to show animation or progress tag.

    animationRepeatIntervalForProgressBar()
    animationDurationForProgressBar()

Because, RenderProgress decides to show update progress bar's animation according to the functions.
I add the functions to EFL port referencing to GTK port.
Comment 1 Gyuyoung Kim 2011-06-15 03:28:21 PDT
Created attachment 97267 [details]
Proposed Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-06-15 06:13:13 PDT
> Source/WebCore/platform/efl/RenderThemeEfl.cpp:1095
> +// These values have been copied from RenderThemeGtk.cpp

I'd rather have all these static consts in the beginning of the file, before the actual method implementations.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:1096
> +static const int progressActivityBlocks = 5;

This one doesn't seem to be used.
Comment 3 Gyuyoung Kim 2011-06-15 08:50:15 PDT
Created attachment 97300 [details]
Patch

Ok, patch is modified.
Comment 4 Leandro Pereira 2011-06-15 09:38:56 PDT
Comment on attachment 97300 [details]
Patch

LGTM.
Comment 5 Kent Tamura 2011-06-15 16:57:28 PDT
Comment on attachment 97300 [details]
Patch

Rubber stamped by me.
Comment 6 WebKit Review Bot 2011-06-15 17:37:14 PDT
Comment on attachment 97300 [details]
Patch

Clearing flags on attachment: 97300

Committed r88985: <http://trac.webkit.org/changeset/88985>
Comment 7 WebKit Review Bot 2011-06-15 17:37:19 PDT
All reviewed patches have been landed.  Closing bug.