Bug 62712 – [EFL] Remove ewk_view_scrolls_process.

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Ryuan Choi]

I don't know ewk_view_tiled too much,
but, I don't know why _ewk_view_tiled_smart_zoom_set calls ewk_view_scrolls_process.
evas_object_smart_calculate(sd->self) will do same thing.

I think that ewk_view_scrolls_process looks no needed.

[Ryuan Choi]

Created attachment 97269 [details]
Patch

[Rafael Antognolli]

Hello Ryuan,

(In reply to comment #0)
> I don't know ewk_view_tiled too much,
> but, I don't know why _ewk_view_tiled_smart_zoom_set calls ewk_view_scrolls_process.
> evas_object_smart_calculate(sd->self) will do same thing.

It doesn't do the same thing, since ewk_view_scrolls_process(sd) will call _ewk_view_tiled_smart_scrolls_process(sd), which does more than just processing offset changes in the backing store. It gets scroll requests stored in the view (sr = ewk_view_scroll_requests_get(sd->_priv, &count)), and add them to the backing store. Then yes, the backing store could process these scroll requests normally.

It also adds these scroll requests, when they are not scrolls of the entire page, as repaint requests, as you can see in the code of this function. Please take a look at it, I think you can't just remove this call without having more problems later when mixing scroll with zoom.

[Ryuan Choi]

(In reply to comment #2)
> Hello Ryuan,
> 
> (In reply to comment #0)
> > I don't know ewk_view_tiled too much,
> > but, I don't know why _ewk_view_tiled_smart_zoom_set calls ewk_view_scrolls_process.
> > evas_object_smart_calculate(sd->self) will do same thing.
> 
> It doesn't do the same thing, since ewk_view_scrolls_process(sd) will call _ewk_view_tiled_smart_scrolls_process(sd), which does more than just processing offset changes in the backing store. It gets scroll requests stored in the view (sr = ewk_view_scroll_requests_get(sd->_priv, &count)), and add them to the backing store. Then yes, the backing store could process these scroll requests normally.
> 
> It also adds these scroll requests, when they are not scrolls of the entire page, as repaint requests, as you can see in the code of this function. Please take a look at it, I think you can't just remove this call without having more problems later when mixing scroll with zoom.

Hello, rafael.
Thanks for your kindness and I almost understand.
I wish to simplify them, but I understand that this patch is not way go.