Bug 62701 - Web Inspector: script select can be too wide.
Summary: Web Inspector: script select can be too wide.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on: 62728
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-15 00:45 PDT by Pavel Podivilov
Modified: 2011-06-15 08:19 PDT (History)
10 users (show)

See Also:

Attachments
Patch. (10.30 KB, patch)
2011-06-15 00:46 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Patch. (9.47 KB, patch)
2011-06-15 00:47 PDT, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Patch. (9.42 KB, patch)
2011-06-15 01:53 PDT, Pavel Podivilov 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-06-15 00:45:27 PDT 
Web Inspector: script select can be too wide.

We should truncate script name in options text (tooltip still displays the whole url).
Comment 1 Pavel Podivilov 2011-06-15 00:46:06 PDT 
Created attachment 97245 [details]
Patch.
Comment 2 Pavel Podivilov 2011-06-15 00:47:35 PDT 
Created attachment 97246 [details]
Patch.
Comment 3 Yury Semikhatsky 2011-06-15 01:41:35 PDT 
Comment on attachment 97246 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=97246&action=review

> LayoutTests/inspector/debugger/scripts-panel-expected.txt:19
> +text: very_looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooon..., tooltip: very_looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong_url

Is result the same on all platforms?
Comment 4 Yury Semikhatsky 2011-06-15 01:48:15 PDT 
Comment on attachment 97246 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=97246&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:304
> +        WebInspector.log(displayName.length);

Remove this line.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:306
> +            displayName = displayName.substring(0, 100) + "...";

Ignore my previous comment about test expectations I thought you were truncating the display name based on the screen width which we probably should do instead of specifying 100 limit for all resolutions.
Comment 5 Pavel Podivilov 2011-06-15 01:53:44 PDT 
Created attachment 97259 [details]
Patch.
Comment 6 Pavel Podivilov 2011-06-15 02:02:53 PDT 
(In reply to comment #4)
> (From update of attachment 97246 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97246&action=review
> 
> > Source/WebCore/inspector/front-end/ScriptsPanel.js:304
> > +        WebInspector.log(displayName.length);
> 
> Remove this line.

Done.
Comment 7 Pavel Podivilov 2011-06-15 03:39:15 PDT 
Committed r88916: <http://trac.webkit.org/changeset/88916>
Comment 8 Pavel Podivilov 2011-06-15 08:19:02 PDT 
Committed r88936: <http://trac.webkit.org/changeset/88936>