Bug 62697 – [CMAKE] Enable METER_TAG of HTML5

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

Enable meter tag among html5 features. I test this feature in http://www.quackit.com/html_5/tags/html_meter_tag.cfm 
Meter tag features is working well on the site.

[Gyuyoung Kim]

Created attachment 97238 [details]
Proposed Patch

[Gyuyoung Kim]

Bug 62211's patch should be landed in order to work this patch.

[Raphael Kubo da Costa (:rakuco)]

It looks OK at first glance.

[Lucas De Marchi]

Comment on attachment 97238 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97238&action=review

> ChangeLog:7
> +        [EFL] Enable METER_TAG of HTML5
> +        https://bugs.webkit.org/show_bug.cgi?id=62697
> +

Since this is not specific to EFL, mind sending this again changing it to [CMAKE] instead of EFL? In fact the ideal would be to split this patch in the generic and specific parts, but since it's very small, I think it's better to just change to [CMAKE] and tell in the log message that it's being enabled for EFL port.

[Gyuyoung Kim]

Created attachment 97285 [details]
Modified Patch

[Leandro Pereira]

Comment on attachment 97285 [details]
Modified Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97285&action=review

> ChangeLog:8
> +        [CMAKE] Enable METER_TAG of HTML5
> +        https://bugs.webkit.org/show_bug.cgi?id=62697
> +
> +        Support meter tag of html5 for EFL port.

You could say "Right now, this is only enabled on the EFL port.", so that you don't repeat yourself (and add nothing to anyone else reading the changelog entry).

[Gyuyoung Kim]

Created attachment 97381 [details]
Modified Patch

Leandro, ChangeLog is modified as much as I can fill. :)

[Leandro Pereira]

Comment on attachment 97381 [details]
Modified Patch

LGTM.

[Eric Seidel (no email)]

Comment on attachment 97381 [details]
Modified Patch

OK.

[WebKit Review Bot]

Comment on attachment 97381 [details]
Modified Patch

Clearing flags on attachment: 97381

Committed r89051: <http://trac.webkit.org/changeset/89051>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.