Pressing space bar key does not pause video in full-screen mode (if user has previously clicked on the video)
Created attachment 97203 [details] Patch
Comment on attachment 97203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97203&action=review > Source/WebCore/html/shadow/MediaControlRootElement.cpp:460 > + setTabIndexExplicitly(0); > + m_savedFocusNode = document()->focusedNode(); > + focus(); Will this send a “blur” event to the currently focused element? That does not seem like a good idea in the full-screen video case.
(In reply to comment #2) > Will this send a “blur” event to the currently focused element? That does not seem like a good idea in the full-screen video case. Yes, it will, and that's a good point. I was trying to keep as much code in the MediaControlRootElement as possible, but perhaps the focus code needs to be moved into Document (where we can change the focused node without sending blur (or onfocusout, etc.) events.
Created attachment 97243 [details] Patch Suppress the blur events sent to objects outside the full-screen element's DOM when the full-screen element is a media element. This may not go far enough, in that the fact focus has been lost is still detectable via CSS. But it should be closer.
This has been up for review for 6 months. Did this actually get landed and just forgotten?
(In reply to comment #5) > This has been up for review for 6 months. Did this actually get landed and just forgotten? Nope, it never was landed, and additionally, it probably doesn't apply cleanly any longer.
Seems like a good fix though. :) Always annoys me when flash-players don't support space-bar to start/stop video. :) Who can move this forward? Do you need a review from someone in particular? Should we obsolete this patch and wait for a new one?
Yes, I'll obsolete, rebase, and re-upload.