RESOLVED FIXED 62679
Add notify handler to trigger MemoryPressureHandler in all builds 
https://bugs.webkit.org/show_bug.cgi?id=62679
Summary Add notify handler to trigger MemoryPressureHandler in all builds
Michael Saboff
Reported 2011-06-14 16:51:17 PDT
Remove the #ifndef NDEBUG around the installation of the SIGUSR2 dispatch for triggering MemoryPressureHandler::respondToMemoryPressure().
Attachments
Proposed patch (1.98 KB, patch)
2011-06-15 09:59 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Updated patch using notify (2.47 KB, patch)
2011-06-18 12:09 PDT, Michael Saboff 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2011-06-15 09:59:19 PDT
Created attachment 97314 [details] Proposed patch
Geoffrey Garen
Comment 2 2011-06-15 14:17:48 PDT
Comment on attachment 97314 [details] Proposed patch r=me
Michael Saboff
Comment 3 2011-06-18 12:09:09 PDT
Created attachment 97703 [details] Updated patch using notify
Darin Adler
Comment 4 2011-06-18 12:11:18 PDT
Comment on attachment 97703 [details] Updated patch using notify View in context: https://bugs.webkit.org/attachment.cgi?id=97703&action=review > Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:55 > +static int notifyToken; This can go inside the function where it’s used instead of at the file level. > Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:72 > + notify_register_dispatch("com.apple.WebKit.lowMemory", &notifyToken, > + dispatch_get_main_queue(), ^(int) { memoryPressureHandler().respondToMemoryPressure();}); This is not WebKit project style indentation. We don't line up things with parentheses on the line before I suggest "org.WebKit.lowMemory" instead of "com.apple.WebKit.lowMemory".
Eric Seidel (no email)
Comment 5 2011-06-18 13:33:04 PDT
Comment on attachment 97314 [details] Proposed patch Cleared Geoffrey Garen's review+ from obsolete attachment 97314 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Michael Saboff
Comment 6 2011-06-19 05:55:49 PDT
Committed r89214: <http://trac.webkit.org/changeset/89214>
Note You need to log in before you can comment on or make changes to this bug.