Bug 62658 - Constant array literals result in unnecessarily large amounts of code
Summary: Constant array literals result in unnecessarily large amounts of code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on: 62672
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-14 11:56 PDT by Oliver Hunt
Modified: 2011-06-14 16:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (15.15 KB, patch)
2011-06-14 11:59 PDT, Oliver Hunt 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-06-14 11:56:28 PDT 
Constant array literals result in unnecessarily large amounts of code
Comment 1 Oliver Hunt 2011-06-14 11:59:25 PDT 
Created attachment 97150 [details]
Patch
Comment 2 Gavin Barraclough 2011-06-14 12:07:16 PDT 
Comment on attachment 97150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97150&action=review

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1551
> +    unsigned checkLength = 0;

This should be #ifndef NDEBUG, or, um, !ASSERT_DISABLED?.  Y'know.
Comment 3 Oliver Hunt 2011-06-14 12:10:37 PDT 
Committed r88841: <http://trac.webkit.org/changeset/88841>
Comment 4 Csaba Osztrogonác 2011-06-14 15:05:21 PDT 
(In reply to comment #3)
> Committed r88841: <http://trac.webkit.org/changeset/88841>

This patch made many tests crash on many platforms. Could you check it?
Comment 5 Ryosuke Niwa 2011-06-14 15:12:33 PDT 
Any update on fix?  We might need to rollout this patch for now if we can't land a fix soon because debug test bots are bailing out due to too many crashes.
Comment 6 Ryosuke Niwa 2011-06-14 16:03:39 PDT 
Per discussion on IRC, I'm rolling out this patch for now.
Comment 8 Oliver Hunt 2011-06-14 16:39:55 PDT 
Committed r88873: <http://trac.webkit.org/changeset/88873>