Bug 62649 - Incorrect #if[n]def for building without DISPATCH_VM_PRESSURE
Summary: Incorrect #if[n]def for building without DISPATCH_VM_PRESSURE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on: 62652
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-14 10:32 PDT by Michael Saboff
Modified: 2011-06-14 16:30 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (1.30 KB, patch)
2011-06-14 10:49 PDT, Michael Saboff
joepeck: review+
Details | Formatted Diff | Diff
Updated patch (1.30 KB, patch)
2011-06-14 15:35 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff
Right updated patch (1.33 KB, patch)
2011-06-14 15:38 PDT, Michael Saboff
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2011-06-14 10:32:59 PDT
The #ifdef DISPATCH_VM_PRESSURE on line 43 of MemoryPressureHandlerMac.mm should actually be #ifndef.
Comment 1 Michael Saboff 2011-06-14 10:49:56 PDT
Created attachment 97140 [details]
Proposed patch
Comment 2 Joseph Pecoraro 2011-06-14 10:51:12 PDT
Comment on attachment 97140 [details]
Proposed patch

Thanks!
Comment 3 Michael Saboff 2011-06-14 10:55:12 PDT
Committed r88823: <http://trac.webkit.org/changeset/88823>
Comment 4 Andy Estes 2011-06-14 11:21:44 PDT
DISPATCH_VM_PRESSURE is an enum, not a macro, so this check doesn't actually work and ends up breaking the build on machines that do have the system header.
Comment 5 Andy Estes 2011-06-14 12:46:50 PDT
http://trac.webkit.org/changeset/88829 rolled this out. Reopening.
Comment 6 Michael Saboff 2011-06-14 15:35:33 PDT
Created attachment 97173 [details]
Updated patch
Comment 7 Michael Saboff 2011-06-14 15:38:14 PDT
Created attachment 97176 [details]
Right updated patch
Comment 8 Joseph Pecoraro 2011-06-14 15:39:28 PDT
Comment on attachment 97176 [details]
Right updated patch

Thanks again.
Comment 9 Michael Saboff 2011-06-14 16:30:42 PDT
Committed r88871: <http://trac.webkit.org/changeset/88871>