Bug 62643 – Web Inspector: "data" URLs not detected in CSS url(...) values properly

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

The actual URLs that are linked to from the url(...) value are relative to the CSS base URL rather than absolute "data" URLs.

Upstreaming http://code.google.com/p/chromium/issues/detail?id=82982

[Alexander Pavlov (apavlov)]

Created attachment 97133 [details]
[PATCH] Suggested fix

[Pavel Feldman]

Comment on attachment 97133 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=97133&action=review

> Source/WebCore/inspector/front-end/AuditRules.js:665
> +            if (!parsedURL || !parsedURL.isDataURL) {

This check seems wrong. Now all parsed non-data urls fall under this branch.

> Source/WebCore/inspector/front-end/CookieItemsView.js:243
> +    if (!url || url.isDataURL || !this.cookieDomainMatchesResourceDomain(cookie.domain, url.host))

Will this work as is?

> Source/WebCore/inspector/front-end/inspector.js:1320
> +        if (parsedHref && (parsedHref.scheme || parsedHref.isDataURL))

No need to change this.

[Alexander Pavlov (apavlov)]

Created attachment 97137 [details]
[PATCH] Comments addressed, a simplified approach applied

[Alexander Pavlov (apavlov)]

Committed: <http://trac.webkit.org/changeset/88920>

[Jonh Wendell]

Created attachment 97284 [details]
Patch

[Pavel Feldman]

Comment on attachment 97284 [details]
Patch

This patch has already landed.

[Jonh Wendell]

(In reply to comment #6)
> (From update of attachment 97284 [details])
> This patch has already landed.

Sorry, it was my mistake while learning how to use Tools/Scripts/webkit-patch