Bug 62643 - Web Inspector: "data" URLs not detected in CSS url(...) values properly
Summary: Web Inspector: "data" URLs not detected in CSS url(...) values properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-14 09:11 PDT by Alexander Pavlov (apavlov)
Modified: 2011-06-15 07:22 PDT (History)
10 users (show)

See Also:


Attachments
[PATCH] Suggested fix (9.46 KB, patch)
2011-06-14 10:15 PDT, Alexander Pavlov (apavlov)
pfeldman: review-
Details | Formatted Diff | Diff
[PATCH] Comments addressed, a simplified approach applied (4.88 KB, patch)
2011-06-14 10:41 PDT, Alexander Pavlov (apavlov)
yurys: review+
Details | Formatted Diff | Diff
Patch (5.13 KB, patch)
2011-06-15 06:28 PDT, Jonh Wendell
pfeldman: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2011-06-14 09:11:21 PDT
The actual URLs that are linked to from the url(...) value are relative to the CSS base URL rather than absolute "data" URLs.

Upstreaming http://code.google.com/p/chromium/issues/detail?id=82982
Comment 1 Alexander Pavlov (apavlov) 2011-06-14 10:15:29 PDT
Created attachment 97133 [details]
[PATCH] Suggested fix
Comment 2 Pavel Feldman 2011-06-14 10:22:00 PDT
Comment on attachment 97133 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=97133&action=review

> Source/WebCore/inspector/front-end/AuditRules.js:665
> +            if (!parsedURL || !parsedURL.isDataURL) {

This check seems wrong. Now all parsed non-data urls fall under this branch.

> Source/WebCore/inspector/front-end/CookieItemsView.js:243
> +    if (!url || url.isDataURL || !this.cookieDomainMatchesResourceDomain(cookie.domain, url.host))

Will this work as is?

> Source/WebCore/inspector/front-end/inspector.js:1320
> +        if (parsedHref && (parsedHref.scheme || parsedHref.isDataURL))

No need to change this.
Comment 3 Alexander Pavlov (apavlov) 2011-06-14 10:41:29 PDT
Created attachment 97137 [details]
[PATCH] Comments addressed, a simplified approach applied
Comment 4 Alexander Pavlov (apavlov) 2011-06-15 05:10:39 PDT
Committed: <http://trac.webkit.org/changeset/88920>
Comment 5 Jonh Wendell 2011-06-15 06:28:37 PDT
Created attachment 97284 [details]
Patch
Comment 6 Pavel Feldman 2011-06-15 07:17:33 PDT
Comment on attachment 97284 [details]
Patch

This patch has already landed.
Comment 7 Jonh Wendell 2011-06-15 07:22:37 PDT
(In reply to comment #6)
> (From update of attachment 97284 [details])
> This patch has already landed.

Sorry, it was my mistake while learning how to use Tools/Scripts/webkit-patch