Bug 62635 - KeywordLookupGenerator's Trie does not work with Python 3
Summary: KeywordLookupGenerator's Trie does not work with Python 3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P5 Enhancement
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-14 07:44 PDT by Benjamin Poulain
Modified: 2011-06-14 09:25 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2011-06-14 08:27 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-06-14 07:44:08 PDT
In Python 3, the dictionary's items() function returns an iterator instead of a list of tuple.
dict.items()[0] cannot work.
Fix that when you have 5 minutes :)
Comment 1 Benjamin Poulain 2011-06-14 08:27:00 PDT
Created attachment 97122 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-06-14 08:45:58 PDT
Comment on attachment 97122 [details]
Patch

Odd that there isn't a nicer way to do this.
Comment 3 Oliver Hunt 2011-06-14 08:47:01 PDT
Comment on attachment 97122 [details]
Patch

Yay for languages that randomly break existing content.
Comment 4 Benjamin Poulain 2011-06-14 08:48:29 PDT
(In reply to comment #2)
> (From update of attachment 97122 [details])
> Odd that there isn't a nicer way to do this.

When we drop support for Python 2.5, we can use the global function next().
Comment 5 Eric Seidel (no email) 2011-06-14 08:52:17 PDT
I see, that wasn't clear to me from your comment for some reason.
Comment 6 WebKit Review Bot 2011-06-14 09:25:16 PDT
Comment on attachment 97122 [details]
Patch

Clearing flags on attachment: 97122

Committed r88807: <http://trac.webkit.org/changeset/88807>
Comment 7 WebKit Review Bot 2011-06-14 09:25:21 PDT
All reviewed patches have been landed.  Closing bug.