Bug 62634 - [GTK] Add a statusbar to MiniBrowser
Summary: [GTK] Add a statusbar to MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-06-14 07:41 PDT by Carlos Garcia Campos
Modified: 2011-06-15 00:51 PDT (History)
1 user (show)

See Also:

Attachments
Patch (8.54 KB, patch)
2011-06-14 07:48 PDT, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-06-14 07:41:25 PDT 
To show the url of the current hovered link, like GtkLauncher does.
Comment 1 Carlos Garcia Campos 2011-06-14 07:48:34 PDT 
Created attachment 97118 [details]
Patch
Comment 2 Martin Robinson 2011-06-14 08:26:38 PDT 
Comment on attachment 97118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97118&action=review

Looks good, but please make the following changes before landing.

> Tools/MiniBrowser/gtk/BrowserWindow.c:47
>      GtkWidget* mainBox;
>      GtkWidget* uriEntry;
> +    GtkWidget *statusBar;
>      WKViewRef webView;
>  
> +    guint statusBarContextId;
> +
>      gchar* title;
>      gdouble loadProgress;

Do you mind cleaning up the rest of this section as well since you're touching it?

> Tools/MiniBrowser/gtk/WebBundle/WebBundleMain.c:35
> +static void mouseDidMoveOverElement(WKBundlePageRef page, WKBundleHitTestResultRef hitTestResult, WKEventModifiers modifiers, WKTypeRef* userData, const void *clientInfo)

The asterisk on WKTypeRef should be on userData.

> Tools/MiniBrowser/gtk/main.c:32
> +WKContextRef processContext;

This could be local and passed as an argument to addInjectedBundleToContext.

> Tools/MiniBrowser/gtk/main.c:35
> +static void initContext()

I'd prefer this to be called something like addInjectedBundleToContext.
Comment 3 Carlos Garcia Campos 2011-06-15 00:51:54 PDT 
Committed r88912: <http://trac.webkit.org/changeset/88912>