Bug 62632 - [Qt] Don't include convenience "QWebFoo" headers in WebKit code.
Summary: [Qt] Don't include convenience "QWebFoo" headers in WebKit code.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Keywords: Qt, QtTriaged
Depends on:
Reported: 2011-06-14 06:35 PDT by Andreas Kling
Modified: 2011-06-14 09:25 PDT (History)
2 users (show)

See Also:

Proposed patch (1.01 KB, patch)
2011-06-14 06:37 PDT, Andreas Kling
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-06-14 06:35:29 PDT
We shouldn't make assumptions about these headers being available and pointing to the right qwebfoo.h
Comment 1 Andreas Kling 2011-06-14 06:37:21 PDT
Created attachment 97107 [details]
Proposed patch
Comment 2 WebKit Review Bot 2011-06-14 06:38:38 PDT
Attachment 97107 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1

Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp:26:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2011-06-14 06:54:21 PDT
Committed r88795: <http://trac.webkit.org/changeset/88795>
Comment 4 Ademar Reis 2011-06-14 09:25:20 PDT
Revision r88795 cherry-picked into qtwebkit-2.2 with commit ceea7a3 <http://gitorious.org/webkit/qtwebkit/commit/ceea7a3>