WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
62627
[GTK] Move the code to show the context menu from WebKitWebViewBase to WebContextMenuProxyGtk
https://bugs.webkit.org/show_bug.cgi?id=62627
Summary
[GTK] Move the code to show the context menu from WebKitWebViewBase to WebCon...
Carlos Garcia Campos
Reported
2011-06-14 02:33:28 PDT
As suggested by Martin in
bug #54827
we could show the context menu directly from WebContextMenuProxyGtk instead of using a private method in WebKitWebViewBase for that.
Attachments
Patch
(6.68 KB, patch)
2011-06-14 02:38 PDT
,
Carlos Garcia Campos
mrobinson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2011-06-14 02:38:33 PDT
Created
attachment 97092
[details]
Patch This patch depends on
bug #62626
since it uses convertWidgetPointToScreenPoint() to position the context menu.
Martin Robinson
Comment 2
2011-06-14 07:58:32 PDT
Comment on
attachment 97092
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=97092&action=review
Thank you for the cleanup!
> Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:89 > + gtk_menu_popdown(m_popup);
I guess this fix is tacked on? It's simple enough that I think it's fine for this patch. For more complicated fixes it's probably better to make seperate bugs.
Carlos Garcia Campos
Comment 3
2011-06-14 08:04:07 PDT
Committed
r88803
: <
http://trac.webkit.org/changeset/88803
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug