Bug 62627 - [GTK] Move the code to show the context menu from WebKitWebViewBase to WebContextMenuProxyGtk
Summary: [GTK] Move the code to show the context menu from WebKitWebViewBase to WebCon...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 62626
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-14 02:33 PDT by Carlos Garcia Campos
Modified: 2011-06-14 08:04 PDT (History)
0 users

See Also:

Attachments
Patch (6.68 KB, patch)
2011-06-14 02:38 PDT, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-06-14 02:33:28 PDT 
As suggested by Martin in bug #54827 we could show the context menu directly from WebContextMenuProxyGtk instead of using a private method in WebKitWebViewBase for that.
Comment 1 Carlos Garcia Campos 2011-06-14 02:38:33 PDT 
Created attachment 97092 [details]
Patch

This patch depends on bug #62626 since it uses convertWidgetPointToScreenPoint() to position the context menu.
Comment 2 Martin Robinson 2011-06-14 07:58:32 PDT 
Comment on attachment 97092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97092&action=review

Thank you for the cleanup!

> Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:89
> +    gtk_menu_popdown(m_popup);

I guess this fix is tacked on? It's simple enough that I think it's fine for this patch. For more complicated fixes it's probably better to make seperate bugs.
Comment 3 Carlos Garcia Campos 2011-06-14 08:04:07 PDT 
Committed r88803: <http://trac.webkit.org/changeset/88803>