Bug 62620 - dump-as-text conversion: editing/deleting/5300379.html
Summary: dump-as-text conversion: editing/deleting/5300379.html
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
Depends on:
Reported: 2011-06-13 20:45 PDT by Wyatt Carss
Modified: 2011-06-14 11:49 PDT (History)
4 users (show)

See Also:

Patch (18.45 KB, patch)
2011-06-13 21:02 PDT, Wyatt Carss
rniwa: review-
Details | Formatted Diff | Diff
Patch (18.65 KB, patch)
2011-06-14 09:09 PDT, Wyatt Carss
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wyatt Carss 2011-06-13 20:45:47 PDT
Pixel test that definitely doesn't need to be -- only supposed to test that backward-deletion-by-word works. Specifically that it doesn't hang and isn't a no-op.
Comment 1 Wyatt Carss 2011-06-13 21:02:08 PDT
Created attachment 97064 [details]
Comment 2 Ryosuke Niwa 2011-06-13 21:14:49 PDT
Comment on attachment 97064 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=97064&action=review

> LayoutTests/editing/deleting/5300379.html:4
> +<div class="description">Sets cursor to 0 in the container above and deletes by word backward, checking for a hang, then inserts 2 words and repeats, to ensure that backward word deletion isn't a no-op.</div>

I'm afraid that adding extra div will cause this hang not to reproduce.  I'd prefer printing this using InsertText as done in the case !window.layoutTestController.

Also, this description is kind of convoluted.  It doesn't really tell us what we're trying to test.  We should at least say that "you should see 'Success' below" because that's the minimum requirement for this test to pass.  Also, setting cursor (note, it's caret/insertion point; cursor usually refers to a mark that indicates the current position of your pointing device) to offset 0 isn't really useful information because the div was empty to begin with.  What's significant is the fact we're deleting word backward in an empty editable div, and we're then making sure deleting word backward will remove exactly one word.
Comment 3 Wyatt Carss 2011-06-14 09:09:50 PDT
Created attachment 97128 [details]
Comment 4 Ryosuke Niwa 2011-06-14 09:55:49 PDT
Comment on attachment 97128 [details]

Comment 5 WebKit Review Bot 2011-06-14 10:07:21 PDT
Comment on attachment 97128 [details]

Rejecting attachment 97128 [details] from commit-queue.

wcarss@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 6 WebKit Review Bot 2011-06-14 11:49:07 PDT
Comment on attachment 97128 [details]

Clearing flags on attachment: 97128

Committed r88840: <http://trac.webkit.org/changeset/88840>
Comment 7 WebKit Review Bot 2011-06-14 11:49:12 PDT
All reviewed patches have been landed.  Closing bug.