Bug 62609 - fast/workers/worker-close.html is flaky on slower machines.
Summary: fast/workers/worker-close.html is flaky on slower machines.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-13 16:55 PDT by David Levin
Modified: 2011-06-13 18:15 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.76 KB, patch)
2011-06-13 16:57 PDT, David Levin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 David Levin 2011-06-13 16:57:52 PDT
Created attachment 97036 [details]
Patch
Comment 2 Dmitry Titov 2011-06-13 17:05:13 PDT
Comment on attachment 97036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97036&action=review

> LayoutTests/fast/workers/worker-close.html:46
> +            timeout = setTimeout(testErrorAfterClose, 1000);

Do we need a 1000ms delay now?
Comment 3 David Levin 2011-06-13 17:11:17 PDT
(In reply to comment #2)
> (From update of attachment 97036 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97036&action=review
> 
> > LayoutTests/fast/workers/worker-close.html:46
> > +            timeout = setTimeout(testErrorAfterClose, 1000);
> 
> Do we need a 1000ms delay now?

The delay wasn't about waiting for this response. It was about waiting to see if it got back a response to the "worker.postMessage("ping");" message.
Comment 4 Dmitry Titov 2011-06-13 17:33:54 PDT
Comment on attachment 97036 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2011-06-13 18:15:39 PDT
Comment on attachment 97036 [details]
Patch

Clearing flags on attachment: 97036

Committed r88746: <http://trac.webkit.org/changeset/88746>
Comment 6 WebKit Review Bot 2011-06-13 18:15:43 PDT
All reviewed patches have been landed.  Closing bug.