Bug 62609 – fast/workers/worker-close.html is flaky on slower machines.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Levin]

For example, http://build.chromium.org/p/chromium/builders/Mac10.5%20Tests%20(1)/builds/8391/steps/ui_tests/logs/stdio

[David Levin]

Created attachment 97036 [details]
Patch

[Dmitry Titov]

Comment on attachment 97036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97036&action=review

> LayoutTests/fast/workers/worker-close.html:46
> +            timeout = setTimeout(testErrorAfterClose, 1000);

Do we need a 1000ms delay now?

[David Levin]

(In reply to comment #2)
> (From update of attachment 97036 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97036&action=review
> 
> > LayoutTests/fast/workers/worker-close.html:46
> > +            timeout = setTimeout(testErrorAfterClose, 1000);
> 
> Do we need a 1000ms delay now?

The delay wasn't about waiting for this response. It was about waiting to see if it got back a response to the "worker.postMessage("ping");" message.

[Dmitry Titov]

Comment on attachment 97036 [details]
Patch

Thanks!

[WebKit Review Bot]

Comment on attachment 97036 [details]
Patch

Clearing flags on attachment: 97036

Committed r88746: <http://trac.webkit.org/changeset/88746>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.