Bug 62607 - [chromium] Disable drawing for huge mask layers
Summary: [chromium] Disable drawing for huge mask layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-13 16:40 PDT by Adrienne Walker
Modified: 2011-06-14 10:44 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.60 KB, patch)
2011-06-13 16:42 PDT, Adrienne Walker
no flags Details | Formatted Diff | Diff
Patch (5.65 KB, patch)
2011-06-13 17:01 PDT, Adrienne Walker
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-06-13 16:40:23 PDT
[chromium] Disable drawing for huge mask layers
Comment 1 Adrienne Walker 2011-06-13 16:42:20 PDT
Created attachment 97032 [details]
Patch
Comment 2 James Robinson 2011-06-13 16:50:43 PDT
Comment on attachment 97032 [details]
Patch

Will we still try to upload tiles for giant mask layers when returning false to drawsContent()?
Comment 3 Adrienne Walker 2011-06-13 17:01:41 PDT
Created attachment 97039 [details]
Patch
Comment 4 Adrienne Walker 2011-06-13 17:02:49 PDT
Excellent point.  We weren't uploading tiles, but we were painting unnecessarily and then holding onto that gigantic paint buffer because the tiler never uploaded it.
Comment 5 James Robinson 2011-06-13 17:12:02 PDT
Comment on attachment 97039 [details]
Patch

Even better!
Comment 6 Adrienne Walker 2011-06-14 10:44:56 PDT
Committed r88822: <http://trac.webkit.org/changeset/88822>