Patch will be updated.
Created attachment 97016 [details] Patch
Comment on attachment 97016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97016&action=review Isn't there any additional files that need to be compiled? Otherwise looks good. > ChangeLog:8 > + Add feature to enable or disable ENABLE_TOUCH_ICON which support supports > Source/cmakeconfig.h.cmake:39 > +#cmakedefine01 ENABLE_TOUCH_ICO_LOADING ICON
Created attachment 97066 [details] Patch
(In reply to comment #2) > (From update of attachment 97016 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97016&action=review > > Isn't there any additional files that need to be compiled? Otherwise looks good. Compiling is fine without any additional files, but we need to investigate move for using those icon. > > > ChangeLog:8 > > + Add feature to enable or disable ENABLE_TOUCH_ICON which support > > supports > > > Source/cmakeconfig.h.cmake:39 > > +#cmakedefine01 ENABLE_TOUCH_ICO_LOADING > > ICON Thanks, done.
(In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 97016 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=97016&action=review > > > > Isn't there any additional files that need to be compiled? Otherwise looks good. > Compiling is fine without any additional files, but we need to investigate move for using those icon. If there are any file that is not specific to EFL or another port, It should be added on this patch as well. You can easily checking this by investigating the build system of other ports that enable this feature (removing the platform/PORT/* and xxxxxPORT.[c|h] files)
Comment on attachment 97066 [details] Patch OK.
Comment on attachment 97066 [details] Patch Clearing flags on attachment: 97066 Committed r88809: <http://trac.webkit.org/changeset/88809>
All reviewed patches have been landed. Closing bug.