Bug 62600 - Make it possible to inline the common case of identifier parsing
Summary: Make it possible to inline the common case of identifier parsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-13 14:39 PDT by Oliver Hunt
Modified: 2011-06-13 15:48 PDT (History)
0 users

See Also:

Attachments
Patch (6.08 KB, patch)
2011-06-13 14:44 PDT, Oliver Hunt 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-06-13 14:39:03 PDT 
Make it possible to inline the common case of identifier parsing
Comment 1 Oliver Hunt 2011-06-13 14:44:28 PDT 
Created attachment 97011 [details]
Patch
Comment 2 Gavin Barraclough 2011-06-13 15:33:06 PDT 
Comment on attachment 97011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97011&action=review

> Source/JavaScriptCore/parser/Lexer.h:92
> +        JSTokenType lexExpectIdentifier(JSTokenData* lvalp, JSTokenInfo* llocp, unsigned, bool strictMode);

lvalp, llocp
(1) These are not necessary in the header.
(2) Say 20 Hail Marys, and please to be making these variables to have the better names.