WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
62600
Make it possible to inline the common case of identifier parsing
https://bugs.webkit.org/show_bug.cgi?id=62600
Summary
Make it possible to inline the common case of identifier parsing
Oliver Hunt
Reported
2011-06-13 14:39:03 PDT
Make it possible to inline the common case of identifier parsing
Attachments
Patch
(6.08 KB, patch)
2011-06-13 14:44 PDT
,
Oliver Hunt
barraclough
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Oliver Hunt
Comment 1
2011-06-13 14:44:28 PDT
Created
attachment 97011
[details]
Patch
Gavin Barraclough
Comment 2
2011-06-13 15:33:06 PDT
Comment on
attachment 97011
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=97011&action=review
> Source/JavaScriptCore/parser/Lexer.h:92 > + JSTokenType lexExpectIdentifier(JSTokenData* lvalp, JSTokenInfo* llocp, unsigned, bool strictMode);
lvalp, llocp (1) These are not necessary in the header. (2) Say 20 Hail Marys, and please to be making these variables to have the better names.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug