RESOLVED FIXED 62584
Make it possible to inline Identifier::equal 
https://bugs.webkit.org/show_bug.cgi?id=62584
Summary Make it possible to inline Identifier::equal
Oliver Hunt
Reported 2011-06-13 11:49:15 PDT
Make it possible to inline Identifier::equal
Attachments
Patch (2.31 KB, patch)
2011-06-13 11:50 PDT, Oliver Hunt 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-06-13 11:50:16 PDT
Created attachment 96984 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-06-13 12:02:26 PDT
Comment on attachment 96984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96984&action=review > Source/JavaScriptCore/runtime/Identifier.h:138 > + inline bool Identifier::equal(const StringImpl* r, const UChar* s, unsigned length) Why isn't it const?
Oliver Hunt
Comment 3 2011-06-13 12:05:44 PDT
(In reply to comment #2) > (From update of attachment 96984 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96984&action=review > > > Source/JavaScriptCore/runtime/Identifier.h:138 > > + inline bool Identifier::equal(const StringImpl* r, const UChar* s, unsigned length) > > Why isn't it const? It's a static method, and therefore can't be :)
Oliver Hunt
Comment 4 2011-06-13 12:12:55 PDT
Committed r88668: <http://trac.webkit.org/changeset/88668>
Note You need to log in before you can comment on or make changes to this bug.