Bug 62584 - Make it possible to inline Identifier::equal
Summary: Make it possible to inline Identifier::equal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-13 11:49 PDT by Oliver Hunt
Modified: 2011-06-13 12:12 PDT (History)
0 users

See Also:

Attachments
Patch (2.31 KB, patch)
2011-06-13 11:50 PDT, Oliver Hunt 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-06-13 11:49:15 PDT 
Make it possible to inline Identifier::equal
Comment 1 Oliver Hunt 2011-06-13 11:50:16 PDT 
Created attachment 96984 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-06-13 12:02:26 PDT 
Comment on attachment 96984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96984&action=review

> Source/JavaScriptCore/runtime/Identifier.h:138
> +    inline bool Identifier::equal(const StringImpl* r, const UChar* s, unsigned length)

Why isn't it const?
Comment 3 Oliver Hunt 2011-06-13 12:05:44 PDT 
(In reply to comment #2)
> (From update of attachment 96984 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96984&action=review
> 
> > Source/JavaScriptCore/runtime/Identifier.h:138
> > +    inline bool Identifier::equal(const StringImpl* r, const UChar* s, unsigned length)
> 
> Why isn't it const?

It's a static method, and therefore can't be :)
Comment 4 Oliver Hunt 2011-06-13 12:12:55 PDT 
Committed r88668: <http://trac.webkit.org/changeset/88668>