WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
62551
r87539
broke HTMLMediaElement url logging
https://bugs.webkit.org/show_bug.cgi?id=62551
Summary
r87539 broke HTMLMediaElement url logging
Eric Carlson
Reported
2011-06-13 10:32:52 PDT
HTMLMediaElement's urlForLogging was broken by
http://trac.webkit.org/changeset/87539
. With logging enabled (defaults write com.apple.Safari WebCoreLogLevel "0x01000000" on OS X), urls are never logged.
Attachments
Patch
(5.09 KB, patch)
2011-06-13 11:05 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-06-13 10:51:57 PDT
What happens instead?
Adam Barth
Comment 2
2011-06-13 10:53:04 PDT
Yeah, that code doesn't may any sense. It's returning a pointer to a temporary that's out of scope! Who wrote that!
Adam Barth
Comment 3
2011-06-13 10:54:44 PDT
I blame Eric. :) /me will fix.
Eric Carlson
Comment 4
2011-06-13 10:57:13 PDT
(In reply to
comment #3
)
> I blame Eric. :) >
Hey now, watch it with the finger pointing - you could put out an eye ;-)
Adam Barth
Comment 5
2011-06-13 11:05:03 PDT
Created
attachment 96975
[details]
Patch
WebKit Review Bot
Comment 6
2011-06-13 11:37:47 PDT
Comment on
attachment 96975
[details]
Patch Clearing flags on attachment: 96975 Committed
r88662
: <
http://trac.webkit.org/changeset/88662
>
WebKit Review Bot
Comment 7
2011-06-13 11:37:52 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug