Bug 62551 - r87539 broke HTMLMediaElement url logging
Summary: r87539 broke HTMLMediaElement url logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-13 10:32 PDT by Eric Carlson
Modified: 2011-06-13 11:37 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.09 KB, patch)
2011-06-13 11:05 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2011-06-13 10:32:52 PDT 
HTMLMediaElement's urlForLogging was broken by http://trac.webkit.org/changeset/87539. With logging enabled (defaults write com.apple.Safari WebCoreLogLevel "0x01000000" on OS X), urls are never logged.
Comment 1 Adam Barth 2011-06-13 10:51:57 PDT 
What happens instead?
Comment 2 Adam Barth 2011-06-13 10:53:04 PDT 
Yeah, that code doesn't may any sense.  It's returning a pointer to a temporary that's out of scope!  Who wrote that!
Comment 3 Adam Barth 2011-06-13 10:54:44 PDT 
I blame Eric.  :)

/me will fix.
Comment 4 Eric Carlson 2011-06-13 10:57:13 PDT 
(In reply to comment #3)
> I blame Eric.  :)
> 
Hey now, watch it with the finger pointing - you could put out an eye ;-)
Comment 5 Adam Barth 2011-06-13 11:05:03 PDT 
Created attachment 96975 [details]
Patch
Comment 6 WebKit Review Bot 2011-06-13 11:37:47 PDT 
Comment on attachment 96975 [details]
Patch

Clearing flags on attachment: 96975

Committed r88662: <http://trac.webkit.org/changeset/88662>
Comment 7 WebKit Review Bot 2011-06-13 11:37:52 PDT 
All reviewed patches have been landed.  Closing bug.