Bug 62519 - Remove FrameLoader::isProcessingUserGesture
Summary: Remove FrameLoader::isProcessingUserGesture
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-12 15:32 PDT by Adam Barth
Modified: 2011-06-12 19:03 PDT (History)
5 users (show)

See Also:


Attachments
Patch (11.34 KB, patch)
2011-06-12 15:36 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (1.50 MB, application/zip)
2011-06-12 16:07 PDT, WebKit Review Bot
no flags Details
Patch (11.49 KB, patch)
2011-06-12 17:51 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (11.47 KB, patch)
2011-06-12 18:24 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-06-12 15:32:30 PDT
Remove FrameLoader::isProcessingUserGesture
Comment 1 Adam Barth 2011-06-12 15:36:33 PDT
Created attachment 96894 [details]
Patch
Comment 2 WebKit Review Bot 2011-06-12 16:07:16 PDT
Comment on attachment 96894 [details]
Patch

Attachment 96894 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8832257

New failing tests:
media/video-seek-by-small-increment.html
media/video-seekable.html
media/video-source-error-no-candidate.html
media/video-source-moved.html
media/video-error-does-not-exist.html
media/video-dom-preload.html
media/video-loop.html
media/video-pause-empty-events.html
media/video-play-pause-exception.html
Comment 3 WebKit Review Bot 2011-06-12 16:07:21 PDT
Created attachment 96895 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Adam Barth 2011-06-12 17:51:30 PDT
Created attachment 96898 [details]
Patch
Comment 5 Eric Seidel (no email) 2011-06-12 18:20:49 PDT
Comment on attachment 96898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96898&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:2379
> +// FIXME: We should remove this function in favor of just call ing ScriptController::processingUserGesture().

call ing
Comment 6 Adam Barth 2011-06-12 18:24:02 PDT
Created attachment 96902 [details]
Patch for landing
Comment 7 WebKit Review Bot 2011-06-12 19:03:37 PDT
Comment on attachment 96902 [details]
Patch for landing

Clearing flags on attachment: 96902

Committed r88622: <http://trac.webkit.org/changeset/88622>
Comment 8 WebKit Review Bot 2011-06-12 19:03:45 PDT
All reviewed patches have been landed.  Closing bug.