Bug 62514 - [Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
Summary: [Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords:
Depends on: 62926
Blocks: 62929
  Show dependency tree / graph
 
Reported: 2011-06-12 10:30 PDT by Robert Hogan
Modified: 2011-06-19 03:53 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.49 KB, patch)
2011-06-12 10:38 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (3.41 KB, patch)
2011-06-18 03:33 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2011-06-12 10:30:48 PDT 
[Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
Comment 1 Robert Hogan 2011-06-12 10:38:23 PDT 
Created attachment 96882 [details]
Patch
Comment 2 Robert Hogan 2011-06-17 12:10:44 PDT 
Committed r89154: <http://trac.webkit.org/changeset/89154>
Comment 3 Ryosuke Niwa 2011-06-17 16:39:15 PDT 
It seems like this patch caused Qt Windows build failure:
http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Debug/builds/24074/steps/compile-webkit/logs/stdio
Comment 4 Robert Hogan 2011-06-17 18:34:32 PDT 
Whoops.i'll take a look in the morning.
Comment 5 Csaba Osztrogonác 2011-06-18 01:43:22 PDT 
Robert, you should have watch the bots after landing instead of
waiting if somebody kick in your ass. :) Please respect 
contributing rules and try to keep the tree green:
http://www.webkit.org/coding/contributing.html

"Your change must at least compile on all platforms."

I had to roll it out to make the bots green again: http://trac.webkit.org/changeset/89191
Comment 6 Robert Hogan 2011-06-18 03:33:57 PDT 
Created attachment 97695 [details]
Patch
Comment 7 Alexey Proskuryakov 2011-06-18 09:34:52 PDT 
Comment on attachment 97695 [details]
Patch

ok
Comment 8 WebKit Review Bot 2011-06-19 03:53:16 PDT 
Comment on attachment 97695 [details]
Patch

Clearing flags on attachment: 97695

Committed r89213: <http://trac.webkit.org/changeset/89213>
Comment 9 WebKit Review Bot 2011-06-19 03:53:21 PDT 
All reviewed patches have been landed.  Closing bug.