Bug 62508 - DocumentParser::appendBytes should use size_t for length instead of int
Summary: DocumentParser::appendBytes should use size_t for length instead of int
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-12 01:01 PDT by Adam Barth
Modified: 2011-06-12 19:05 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.75 KB, patch)
2011-06-12 01:03 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-06-12 01:01:55 PDT
DocumentParser::appendBytes should use size_t for length instead of int
Comment 1 Adam Barth 2011-06-12 01:03:10 PDT
Created attachment 96871 [details]
Patch
Comment 2 Darin Adler 2011-06-12 18:27:46 PDT
Comment on attachment 96871 [details]
Patch

Looks like all these call sites ignored the argument, except for DecodedDataDocumentParser::appendBytes, which turned around and passed it to a function that takes size_t. So this patch is pure goodness.
Comment 3 Adam Barth 2011-06-12 18:30:42 PDT
(In reply to comment #2)
> (From update of attachment 96871 [details])
> Looks like all these call sites ignored the argument, except for DecodedDataDocumentParser::appendBytes, which turned around and passed it to a function that takes size_t. So this patch is pure goodness.

Yep!
Comment 4 WebKit Review Bot 2011-06-12 19:05:40 PDT
Comment on attachment 96871 [details]
Patch

Clearing flags on attachment: 96871

Committed r88623: <http://trac.webkit.org/changeset/88623>
Comment 5 WebKit Review Bot 2011-06-12 19:05:44 PDT
All reviewed patches have been landed.  Closing bug.