Bug 62502 – Allow setting content-disposition for blob-data

• Status: UNCONFIRMED
• Component: WebCore Misc.

[Sadrul Habib Chowdhury]

It is currently possible to set the content-type for blob-data. This patch also allows setting content-disposition.

[Sadrul Habib Chowdhury]

Created attachment 96858 [details]
patch

I have added the tests, but haven't yet been able to run; keep getting "unexpected no expected result found" errors. Will update the patch if I can get the tests to run successfully and any change is necessary. But please take a look if the approach is OK.

[WebKit Review Bot]

Comment on attachment 96858 [details]
patch

Attachment 96858 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8829578

New failing tests:
fast/files/blob-content-disposition.html

[WebKit Review Bot]

Created attachment 96859 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Adam Barth]

Comment on attachment 96858 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96858&action=review

> Source/WebCore/fileapi/WebKitBlobBuilder.idl:2
> - * Copyright (C) 2010 Google Inc. All rights reserved.
> + * Copyright (C) 2011 Google Inc. All rights reserved.

nit: WebKit appends years to the copyright line rather than replacing them.  No idea why.

[Sadrul Habib Chowdhury]

Comment on attachment 96858 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96858&action=review

>> Source/WebCore/fileapi/WebKitBlobBuilder.idl:2
>> + * Copyright (C) 2011 Google Inc. All rights reserved.
> 
> nit: WebKit appends years to the copyright line rather than replacing them.  No idea why.

Changed. Thanks.

[Sadrul Habib Chowdhury]

Created attachment 96860 [details]
Fix license headers + test

[Sadrul Habib Chowdhury]

Created attachment 96862 [details]
patch

[Sadrul Habib Chowdhury]

Created attachment 96863 [details]
patch

[WebKit Review Bot]

Comment on attachment 96863 [details]
patch

Attachment 96863 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8833016

New failing tests:
fast/files/blob-content-disposition.html

[WebKit Review Bot]

Created attachment 96865 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Sadrul Habib Chowdhury]

Created attachment 96867 [details]
Fixed test, for real this time!

Finally figured out how to test the test! Please take a look!

[Adam Barth]

Comment on attachment 96867 [details]
Fixed test, for real this time!

Is this in the spec?  Marking this R- for now.  Please feel to renominate if this is in the spec (I couldn't find it).

[Sadrul Habib Chowdhury]

This indeed is not in the spec (http://www.w3.org/TR/file-writer-api/#widl-BlobBuilder-getBlob).