RESOLVED FIXED 62501
Add TextRun charactersLength member 
https://bugs.webkit.org/show_bug.cgi?id=62501
Summary Add TextRun charactersLength member
Nikolas Zimmermann
Reported 2011-06-11 01:42:03 PDT
Propagate the maximum length of the characters buffer to the TextRun, even when we're only processing a substring. eg. in RenderText, when we're measuring: 'len' glyphs starting from 'text()->characters() + start', then there's a remaining length of 'textLength() - start' that we're not processing. When integrating SVG Fonts with the GlyphPage concept this information is needed to properly handle ligatures. Currently this is done by a special floatWidthUsingSVGFont that takes an "int& extraCharsAvailable" parameter. This generalizes the concept.
Attachments
Patch (13.88 KB, patch)
2011-06-11 02:09 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v2 (16.38 KB, patch)
2011-06-11 04:17 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2011-06-11 02:09:09 PDT
Created attachment 96852 [details] Patch
Nikolas Zimmermann
Comment 2 2011-06-11 04:17:37 PDT
Created attachment 96855 [details] Patch v2 Fix win/wx build.
Dirk Schulze
Comment 3 2011-06-11 09:50:32 PDT
Comment on attachment 96855 [details] Patch v2 LGTM. Please think about renaming m_len to a more meaningful name in a follow up patch. r=me
Nikolas Zimmermann
Comment 4 2011-06-12 05:41:47 PDT
Landed in r88613.
Note You need to log in before you can comment on or make changes to this bug.