Bug 62495 - combine windows and mac kill-old-processes script
Summary: combine windows and mac kill-old-processes script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-10 18:30 PDT by Lucas Forschler
Modified: 2011-06-18 13:49 PDT (History)
4 users (show)

See Also:

Attachments
Patch to make OS agnostic script. (6.16 KB, patch)
2011-06-13 15:51 PDT, Lucas Forschler 		no flags Details | Formatted Diff | Diff
Patch to make OS agnostic script. (6.21 KB, patch)
2011-06-13 15:57 PDT, Lucas Forschler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2011-06-10 18:30:40 PDT 
Currently a windows specific kill-old-processes script exists, and a mac-specific script exists.
We should combine the logic for these into one script, which will save complexity in the buildbot config steps.
Comment 1 Lucas Forschler 2011-06-13 15:51:18 PDT 
Created attachment 97023 [details]
Patch to make OS agnostic script.
Comment 2 WebKit Review Bot 2011-06-13 15:53:59 PDT 
Attachment 97023 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog']" exit_code: 1

Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Lucas Forschler 2011-06-13 15:57:41 PDT 
Created attachment 97024 [details]
Patch to make OS agnostic script.
Comment 4 Stephanie Lewis 2011-06-13 16:34:48 PDT 
Comment on attachment 97023 [details]
Patch to make OS agnostic script.

View in context: https://bugs.webkit.org/attachment.cgi?id=97023&action=review

you should fix the style issue and then I will add r=me

> Tools/BuildSlaveSupport/mac/kill-old-processes:-50
> -    sys.exit(main())

Do you need to remove the window script as well?
Comment 5 Lucas Forschler 2011-06-13 17:08:35 PDT 
The Style issue has been fixed (see new patch).
Comment 6 Lucas Forschler 2011-06-13 17:09:46 PDT 
Note: I am not removing the windows script as the webkit build master still references it.  Removing it would break existing webkit bots until we could update the webkit master.
Comment 7 Eric Seidel (no email) 2011-06-14 08:51:03 PDT 
Comment on attachment 97024 [details]
Patch to make OS agnostic script.

View in context: https://bugs.webkit.org/attachment.cgi?id=97024&action=review

> Tools/BuildSlaveSupport/kill-old-processes:32
> +    tasksToKillWin = [ "cl.exe", 
> +					"devenv.com", 
> +					"devenv.exe", 

funny indent here.  Tabs?
Comment 8 WebKit Review Bot 2011-06-14 15:23:48 PDT 
Comment on attachment 97024 [details]
Patch to make OS agnostic script.

Clearing flags on attachment: 97024

Committed r88857: <http://trac.webkit.org/changeset/88857>
Comment 9 WebKit Review Bot 2011-06-14 15:23:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Eric Seidel (no email) 2011-06-18 13:49:49 PDT 
Comment on attachment 97023 [details]
Patch to make OS agnostic script.

Cleared review? from obsolete attachment 97023 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).