Bug 62468 - IndexedDB test: complex keyPaths
Summary: IndexedDB test: complex keyPaths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-10 12:50 PDT by Mark Pilgrim (Google)
Modified: 2011-06-13 14:26 PDT (History)
4 users (show)

See Also:


Attachments
Patch (7.83 KB, patch)
2011-06-10 12:54 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-06-10 12:50:49 PDT
This test creates a series of object stores with increasingly complex keyPaths, adds values that conform to those keyPaths, then opens a cursor and checks that the key was properly extracted from the keyPath.

NOTE: this test includes some variations of keyPath that are supported by WebKit but not supported by spec text (specifically using positional array indexes as well as object name identifiers). Support for positional indexes is under discussion on public-webapps.

WebKit passes this test.
Comment 1 Mark Pilgrim (Google) 2011-06-10 12:54:31 PDT
Created attachment 96772 [details]
Patch
Comment 2 David Grogan 2011-06-10 17:23:53 PDT
Comment on attachment 96772 [details]
Patch

LGTM
Comment 3 Gyuyoung Kim 2011-06-13 02:48:52 PDT
Comment on attachment 96772 [details]
Patch

Attachment 96772 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/8829975
Comment 4 Tony Chang 2011-06-13 10:38:26 PDT
Comment on attachment 96772 [details]
Patch

The efl bot error seems unrelated since it's not linking properly and this is just a new layout test.
Comment 5 WebKit Review Bot 2011-06-13 11:53:42 PDT
Comment on attachment 96772 [details]
Patch

Clearing flags on attachment: 96772

Committed r88665: <http://trac.webkit.org/changeset/88665>
Comment 6 WebKit Review Bot 2011-06-13 11:53:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Mark Pilgrim (Google) 2011-06-13 14:26:55 PDT
Thanks Tony.